libzip: use conf_data not zipconf_data in meson.build for HAVE_SHARED #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ret2libc
requested review from
kazarmy,
thestr4ng3r,
wargio and
XVilka
as code owners
kazarmy
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
HAVE_SHARED is in libzip/config.h, not in zipconf.h, so use conf_data instead of the wrong zipconf_data. Anyway, that line should almost never be used because when libzip subproject is used, it should be compiled statically unless someone changes stuff manually. However, it seems that somehow someone was able to trigger that line by using a dirty build dir.
Test plan
...
Closing issues
...