Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analysis_arm_cs.c: Fix -Wmaybe-uninitialized warning in optimized capstone-v3 build #800

Merged
merged 1 commit into from Mar 9, 2021

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Mar 9, 2021

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the rizin book with the relevant information (if needed)

Detailed description

This pr fixes the following warning in the capstone-v3 build of #260 (https://github.com/rizinorg/rizin/runs/2065028270#step:12:1323):

analysis_arm_cs_maybe_uninitialized

This is basically a mechanical blindfix which practically initializes i to 1, but since we don't run tests on capstone-v3 I'm not sure whether it's worth going deeper on this.

Test plan

All builds are green.

Closing issues

...

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #800 (1d3b29b) into dev (2d3ecfc) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #800      +/-   ##
==========================================
- Coverage   42.80%   42.79%   -0.01%     
==========================================
  Files         871      871              
  Lines      316847   316850       +3     
==========================================
- Hits       135626   135609      -17     
- Misses     181221   181241      +20     
Impacted Files Coverage Δ
librz/analysis/p/analysis_arm_cs.c 75.68% <ø> (ø)
librz/socket/rzpipe.c 44.32% <0.00%> (-10.57%) ⬇️
librz/util/intervaltree.c 94.51% <0.00%> (+0.03%) ⬆️
librz/util/pj.c 86.22% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3ecfc...1d3b29b. Read the comment docs.

@kazarmy kazarmy merged commit bed1426 into rizinorg:dev Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants