Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rz-pipe support for Ruby #6

Merged
merged 3 commits into from
Jan 20, 2021
Merged

Conversation

officialcjunior
Copy link
Member

@officialcjunior officialcjunior commented Jan 17, 2021

Description

  • Add rz-pipe support for Ruby:
    Copied the files from the directory 'unmaintained', renamed the necessary variables and made it into a working condition.

Test plan

  • Discuss on the license as it didn't have one.

@XVilka
Copy link
Member

XVilka commented Jan 19, 2021

Please add also a way to test like it's done in #7 (after it's merged).

@officialcjunior
Copy link
Member Author

Please add also a way to test like it's done in #7 (after it's merged).

Would just getting a Makefile which does ruby rzpipe.rb and the test (just like the Go's one) would do?

@XVilka
Copy link
Member

XVilka commented Jan 19, 2021

Yes, should be enough, at least for now. Later we can address this with #8

Also add Ruby to the list of supported languages on the README
@officialcjunior
Copy link
Member Author

Rebased. Please check again now, @XVilka.

@XVilka XVilka merged commit e8e6dd6 into rizinorg:master Jan 20, 2021
@officialcjunior
Copy link
Member Author

Now, this can go on the README, right?

@XVilka
Copy link
Member

XVilka commented Jan 20, 2021

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants