Hexagon adapter and small additions #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wargio
approved these changes
Dec 3, 2023
XVilka
approved these changes
Dec 3, 2023
This is necessary if architectures need the context they are embedded in. Context means: Instruction word +- x bytes. For Hexagon the disassembly and IL steps are incorrect, if the context is not the same every time and differs from the actual binary. Because instructions disassemble differently depending on their neighbors. If the neighbor instruction of a packet indicated the start of it, and during the IL step execution this neighboring instructions is no longer the same, the interpretation is different and the IL step is invalid.
If the sf bytes contain a '\0' byte, the code.size() call later returned the wrong size. Hence we directly read it as ut8 *
If the post-operand list had a register twice in it and the last entry had the correct value, a mismatch happened anyway. Because the first value was tested and did not match. This is not correct, since multiple writes to a register can happen. Only the last post-operand should be considered.
|
@thestr4ng3r Please take a quick look and merge if ok. Personally I wouldn't squash it. But if you prefer it, let me know please. |
|
ping |
thestr4ng3r
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.