Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json file hightlight #3899

Closed
liux-pro opened this issue Jan 16, 2022 · 6 comments
Closed

Json file hightlight #3899

liux-pro opened this issue Jan 16, 2022 · 6 comments

Comments

@liux-pro
Copy link

{
	"lint:js": "eslint",
	"abc":"xyz"
}

Json like this in notepad3 highlight show
image

If there is : in key of json object ,hight light not work

@rdipardo
Copy link

The JSON lexer is also a JSON-LD lexer

* @brief Lexer for JSON and JSON-LD formats

A string in the form prefix:suffix matches a compact IRI in JSON-LD

BTW, if the property name contains an extra colon, it won't match the JSON-LD syntax anymore:

notepad3_dark_theme_package json

@hpwamr
Copy link
Collaborator

hpwamr commented Jan 28, 2022

Hello @liux-pro ,

Feel free to test the "BETA/RC PortableApps", version "Notepad3Portable_5.22.128.3_beta.paf" or newer, see 1st list in issue #1129.

"Notepad3Portable BETA/RC PortableApps" version can be used with or without ".7z" extension.

Also, feel free to test the "BETA/RC Setup", version "Notepad3_5.22.128.3_beta_Setup" or newer, see the 2nd list in issue #1129.

Comments and suggestions are welcome... 😃

@rdipardo
Copy link

rdipardo commented Jan 29, 2022

The real fix was made in 76cbde5.

The last beta release doesn't have a dedicated style for npm scripts that match with SCE_JSON_COMPACTIRI:

notepad3_v5 22 128 3_beta

Notepad3 (x64) v5.22.128.3 beta (dkt1-amr)
Compiler: MS Visual C++ 2022 v17.0.5 (VC v1930)
OS Version: Windows 11  Version 21H2 (Build 22000)
Windows Colors 'Dark-Mode' Theme is SUPPORTED and SELECTED.
Scintilla v515
Lexilla v514
Oniguruma v7.0.0
- Process is not elevated
- User is not in Admin-Group
- Locale -> en-US (CP:'ANSI (CP-65001)')
- Current Encoding -> 'Unicode (UTF-8)'
- Dark-Mode enabled -> YES
- Screen-Resolution -> 1920 x 1080 [pix]
- Display-DPI -> 120 x 120  (Scale: 125%).
- Rendering-Technology -> 'DIRECT-WRITE'
- Zoom -> 100%.
- Current Lexer -> 'JSON'

@hpwamr
Copy link
Collaborator

hpwamr commented Jan 29, 2022

The real fix was made in 76cbde5.

Hello @liux-pro , @rdipardo ,

Feel free to test the "BETA/RC PortableApps", version "Notepad3Portable_5.22.129.1_beta.paf" or newer, see 1st list in issue #1129.

"Notepad3Portable BETA/RC PortableApps" version can be used with or without ".7z" extension.

Also, feel free to test the "BETA/RC Setup", version "Notepad3_5.22.129.1_beta_Setup" or newer, see the 2nd list in issue #1129.

Comments and suggestions are welcome... 😃

@rdipardo
Copy link

5.22.129.1 styles everything as intended 👍🏼

It might be better if the default SCE_JSON_COMPACTIRI style reused the SCE_JSON_PROPERTYNAME style.

It's not my issue, but I think @liux-pro was expecting all property names to look the same. Switching into a JSON-LD style in the middle of a plain JSON document is a potential source of confusion.

It's also a bit harder to see the colon separators next to compact IRIs; by default they're practically the same colour:

notepad3_dark_5 22 129 1_beta

notepad3_5 22 129 1_beta

Notepad3 (x64) v5.22.129.1 beta (dkt1-amr)
Compiler: MS Visual C++ 2022 v17.0.5 (VC v1930)
OS Version: Windows 11  Version 21H2 (Build 22000)
Windows Colors 'Dark-Mode' Theme is SUPPORTED and SELECTED.
Scintilla v515
Lexilla v514
Oniguruma v7.0.0
- Process is not elevated
- User is not in Admin-Group
- Locale -> en-US (CP:'ANSI (CP-65001)')
- Current Encoding -> 'Unicode (UTF-8)'
- Dark-Mode enabled -> NO
- Screen-Resolution -> 1920 x 1080 [pix]
- Display-DPI -> 120 x 120  (Scale: 125%).
- Rendering-Technology -> 'DIRECT-WRITE'
- Zoom -> 100%.
- Current Lexer -> 'JSON'

@hpwamr
Copy link
Collaborator

hpwamr commented Dec 28, 2022

Hello @liux-pro , @rdipardo ,

Feel free to test the "BETA/RC PortableApps", version "Notepad3Portable_5.22.1228.1_rc2.paf" or newer, see in issue #1129.

"Notepad3Portable BETA/RC PortableApps" version can be used with or without ".7z" extension.

Also, feel free to test the "BETA/RC Setup", version "Notepad3_5.22.1228.1_rc2_Setup" or newer, see the 2nd list in issue #1129.

Comments and suggestions are welcome... 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants