Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows spaced path fix #86

Merged
merged 5 commits into from Jun 30, 2016
Merged

Windows spaced path fix #86

merged 5 commits into from Jun 30, 2016

Conversation

rizowski
Copy link
Owner

Fixes #84

  • Pulled out the child spawn calls to utilize more of what happened when a process exits. (Was it fatal? or was it expected)
  • more debug log statements
  • Also made it so that the external process will listen to the parent's stdin (might fix Ctrl+C must be hit twice to kill parallel tasks #80 ?)
    • Stdout and stderr are now pipe
  • Thank god for 96% code coverage. 😄 (this might go down with the new executer script)
  • Appveyor was added back in
  • Watcher directory is specified to ./ if one is not provided in the optionator options.

@coryhouse
Copy link

Awesome! Sorry for the delay, I've been away at a conference. In order to test this, I'm referencing this branch in my package.json like this:

"git://github.com/rizowski/eslint-watch.git#path-fix": "",

That syntax throws an error. Are you aware of an easy way for me to reference this branch in package.json?

@rizowski
Copy link
Owner Author

@coryhouse this should work

"eslint-watch": "git+https://github.com/rizowski/eslint-watch.git#path-fix"

@coryhouse
Copy link

Hrmm, still no luck.

| => npm install
npm ERR! git rev-list -n1 path-fix@: fatal: ambiguous argument 'path-fix@': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 path-fix@: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 path-fix@: 'git [...] -- [...]'

@rizowski
Copy link
Owner Author

rizowski commented Jun 27, 2016

@coryhouse How about this:
npm i -D eslint-watch@https://github.com/rizowski/eslint-watch.git#path-fix

@coryhouse
Copy link

@rizowski Success! The branch works with spaces in the path on Windows. 👍

One issue: With this branch, chalk coloring doesn't come through on the output. As you can see, I lost coloring after installing the branch:
coloring lost

@rizowski
Copy link
Owner Author

@coryhouse The color being gone is interesting. I have noticed you can reenable it by passing --color Not sure what is causing it to not be defaulted yet.

@rizowski
Copy link
Owner Author

@coryhouse I am going to be gone for a couple of weeks. So I am going to pull this in without the color since, while color is nice, doesn't affect how the tool works. I will create an issue about the color and hopefully fix it while I am working on other things.

@coryhouse
Copy link

Thanks so much for your hard work on this!

@rizowski
Copy link
Owner Author

Yeah no problem! Thanks for being a supporter! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paths with spaces aren't supported Ctrl+C must be hit twice to kill parallel tasks
2 participants