Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NA values #110

Merged
merged 8 commits into from
Jun 3, 2022
Merged

Allow NA values #110

merged 8 commits into from
Jun 3, 2022

Conversation

rjake
Copy link
Owner

@rjake rjake commented Jun 3, 2022

Closes #109
Also checks for compare_values() with length > 1

@codecov-commenter
Copy link

Codecov Report

Merging #110 (1f5cba3) into main (5af3ec1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          265       280   +15     
=========================================
+ Hits           265       280   +15     
Impacted Files Coverage Δ
R/compare-values.R 100.00% <100.00%> (ø)
R/headline.R 100.00% <100.00%> (ø)

@rjake rjake merged commit e4547d2 into main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

headline fails on NA values
2 participants