Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegationMap? #1

Closed
tieskedh opened this issue Feb 12, 2018 · 0 comments
Closed

delegationMap? #1

tieskedh opened this issue Feb 12, 2018 · 0 comments

Comments

@tieskedh
Copy link

To learn a codebase, I refactor stuff.
I like how the codebase is built!
I got a bit to excited with refactoring, so I break it down before I hijack your project...
So at the moment, it's not compiling.

I made a class DelegationMap to which the fields are delegated as well as some refreshing-logic.
I intentionally wanted to just create a delegationClass for the fields, but that would create a lot of objects, therefor I grouped them.
The advantage now is that it's very easy to store state and getSnStyle is a lot easier as well.
So, it's up to you if you want (it) to continue this direction.
my current refactorings can be found overhere: https://github.com/tieskedh/kvision/tree/refactoring/delegates

Keep up the good work!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant