You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To learn a codebase, I refactor stuff.
I like how the codebase is built!
I got a bit to excited with refactoring, so I break it down before I hijack your project...
So at the moment, it's not compiling.
I made a class DelegationMap to which the fields are delegated as well as some refreshing-logic.
I intentionally wanted to just create a delegationClass for the fields, but that would create a lot of objects, therefor I grouped them.
The advantage now is that it's very easy to store state and getSnStyle is a lot easier as well.
So, it's up to you if you want (it) to continue this direction.
my current refactorings can be found overhere: https://github.com/tieskedh/kvision/tree/refactoring/delegates
Keep up the good work!!!
The text was updated successfully, but these errors were encountered:
To learn a codebase, I refactor stuff.
I like how the codebase is built!
I got a bit to excited with refactoring, so I break it down before I hijack your project...
So at the moment, it's not compiling.
I made a class DelegationMap to which the fields are delegated as well as some refreshing-logic.
I intentionally wanted to just create a delegationClass for the fields, but that would create a lot of objects, therefor I grouped them.
The advantage now is that it's very easy to store state and getSnStyle is a lot easier as well.
So, it's up to you if you want (it) to continue this direction.
my current refactorings can be found overhere: https://github.com/tieskedh/kvision/tree/refactoring/delegates
Keep up the good work!!!
The text was updated successfully, but these errors were encountered: