Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test::More version mismatch #5

Closed
pghmcfc opened this issue Sep 17, 2013 · 7 comments
Closed

Test::More version mismatch #5

pghmcfc opened this issue Sep 17, 2013 · 7 comments

Comments

@pghmcfc
Copy link

pghmcfc commented Sep 17, 2013

META.* specify a Test::More version requirement of 0.47 but t/00-compile.t requires version 0.88 (for done_testing); examples/exception_like.t would also require version 0.88 for the same reason.

@pghmcfc
Copy link
Author

pghmcfc commented Sep 17, 2013

t/000-report-versions-tiny.t also uses done_testing and hence needs Test::More 0.88.

@pghmcfc
Copy link
Author

pghmcfc commented Sep 17, 2013

In fact, Test::More 0.95_01 or later is needed for t/todo.t, for the change:

    * Test::Builder::Tester now sets $tb->todo_output to the output handle and
      not the error handle (to be in accordance with the default behaviour of
      Test::Builder and allow for testing TODO test behaviour).

With older versions of Test::More, the test fails:

$ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/00-compile.t ................ ok
# 
# 
# Generated by Dist::Zilla::Plugin::ReportVersions::Tiny v1.09
# perl: 5.010001 (wanted any version) on linux from /usr/bin/perl
# 
# Capture::Tiny                                 => 0.22       (want any version)
# Carp                                          => 1.11       (want any version)
# Exporter                                      => 5.63       (want 5.57)   
# ExtUtils::MakeMaker                           => 6.55_02    (want 6.30)   
# Test::Builder                                 => 0.94       (want any version)
# Test::Builder::Tester                         => 1.18       (want any version)
# Test::More                                    => 0.94       (want 0.47)   
# Test::Pod                                     => 1.48       (want 1.41)   
# Try::Tiny                                     => 0.18       (want 0.07)   
# blib                                          => 1.04       (want any version)
# overload                                      => 1.07       (want any version)
# strict                                        => 1.04       (want any version)
# version                                       => 0.9904     (want 0.9901) 
# warnings                                      => 1.06       (want any version)
# 
# Thanks for using my code.  I hope it works for you.
# If not, please try and include this output in the bug report.
# That will help me reproduce the issue and solve your problem.
# 
t/000-report-versions-tiny.t .. ok
t/basic.t ..................... ok
t/like-exception.t ............ ok
#   Failed test '$TODO works'
#   at t/todo.t line 26.
# STDOUT is:
# not ok 1 - succeeded # TODO unimplemented
# ok 2 - no exceptions # TODO unimplemented
# 
# not:
# not ok 1 - succeeded # TODO unimplemented
# #   Failed (TODO) test 'succeeded'
# #   at t/todo.t line 24.
# #          got: '0'
# #     expected: '1'
# ok 2 - no exceptions # TODO unimplemented
# 
# as expected
# STDERR is:
# #   Failed (TODO) test 'succeeded'
# #   at t/todo.t line 24.
# #          got: '0'
# #     expected: '1'
# 
# not:
# 
# as expected
#   Failed test '$TODO works'
#   at t/todo.t line 45.
# STDOUT is:
# not ok 1 - succeeded # TODO unimplemented
# ok 2 - no exceptions # TODO unimplemented
# 
# not:
# not ok 1 - succeeded # TODO unimplemented
# #   Failed (TODO) test 'succeeded'
# #   at t/todo.t line 43.
# #          got: '0'
# #     expected: '1'
# ok 2 - no exceptions # TODO unimplemented
# 
# as expected
# STDERR is:
# #   Failed (TODO) test 'succeeded'
# #   at t/todo.t line 43.
# #          got: '0'
# #     expected: '1'
# 
# not:
# 
# as expected
t/todo.t ...................... 
Failed 4/4 subtests 
#   Failed test '$TODO works'
#   at t/todo.t line 74.
# STDOUT is:
# not ok 1 - succeeded # TODO unimplemented
# ok 2 - no exceptions # TODO unimplemented
# 
# not:
# not ok 1 - succeeded # TODO unimplemented
# #   Failed (TODO) test 'succeeded'
# #   at t/todo.t line 72.
# #          got: '0'
# #     expected: '1'
# ok 2 - no exceptions # TODO unimplemented
# 
# as expected
# STDERR is:
# #   Failed (TODO) test 'succeeded'
# #   at t/todo.t line 72.
# #          got: '0'
# #     expected: '1'
# 
# not:
# 
# as expected
#   Failed test '$TODO works'
#   at t/todo.t line 110.
# STDOUT is:
# not ok 1 - succeeded # TODO unimplemented
# ok 2 - no exceptions # TODO unimplemented
# ok 3 - level 1 # TODO unimplemented
# 
# not:
# not ok 1 - succeeded # TODO unimplemented
# #   Failed (TODO) test 'succeeded'
# #   at t/todo.t line 108.
# #          got: '0'
# #     expected: '1'
# ok 2 - no exceptions # TODO unimplemented
# ok 3 - level 1 # TODO unimplemented
# 
# as expected
# STDERR is:
# #   Failed (TODO) test 'succeeded'
# #   at t/todo.t line 108.
# #          got: '0'
# #     expected: '1'
# 
# not:
# 
# as expected
Test Summary Report
-------------------
t/todo.t                    (Wstat: 0 Tests: 4 Failed: 4)
  Failed tests:  1-4
Files=5, Tests=18,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.25 cusr  0.02 csys =  0.30 CPU)
Result: FAIL

@pghmcfc pghmcfc closed this as completed Sep 17, 2013
@pghmcfc pghmcfc reopened this Sep 17, 2013
@pghmcfc
Copy link
Author

pghmcfc commented Sep 17, 2013

Whoops, closed by accident there.

@rjbs
Copy link
Owner

rjbs commented Sep 17, 2013

Thanks, fixed. This had been rolled back for https://rt.cpan.org/Ticket/Display.html?id=62699 but fixing a number of upstream plugins to get this working in a seven year old version of Perl with no other external libraries is not worth it.

@rjbs rjbs closed this as completed Sep 17, 2013
@pghmcfc
Copy link
Author

pghmcfc commented Sep 17, 2013

That CPAN ticket was me too...

I'm fine with this by the way, just wanted to make sure everything was consistent. It does mean though that the current Test::Fatal can't be built on any current Red Hat Enterprise Linux release (EL-6 has Test-Simple 0.92).

@rjbs
Copy link
Owner

rjbs commented Sep 17, 2013

Thanks, I appreciated both tickets. :) I wouldn't mind seeing it made to work on the older Test::More but… well, I'm not gonna get to it myself. :(

Thanks again!

@karenetheridge
Copy link
Contributor

t/00-compile.t as generated from the latest version of the plugin doesn't require Test::More 0.88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants