RT#67694: Fix a potential infinite-loop condition.

rjray · Aug 14, 2011 · 9babd1c · 9babd1c
1 parent 294c25c
commit 9babd1c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/lib/Apache/RPC/Server.pm b/lib/Apache/RPC/Server.pm
@@ -158,6 +158,10 @@ sub handler ($$) ## no critic (ProhibitExcessComplexity)
         while ($length)
         {
             $r->read($content, ($length < 2048) ? $length : 2048);
+            # If $content is undef, then the client has closed the connection
+            # on its end, and we're done (like it or not).
+            last if (! defined $content);
+
             $length -= length $content;
             if ($do_compress)
             {