Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expat parser subclass is protected against ext ent attack, libxml isn't #3

Merged
merged 1 commit into from
Jun 16, 2011
Merged

Expat parser subclass is protected against ext ent attack, libxml isn't #3

merged 1 commit into from
Jun 16, 2011

Conversation

yannk
Copy link
Contributor

@yannk yannk commented Jun 13, 2011

  • Add tests for libxml and expat parser.
  • Expat was behaving correctly, but LibXML wasn't

@yannk
Don't allow external entities
bc3a6e6 
Add tests for libxml and expat parser.
Expat was behaving correctly, but LibXML wasn't
@rjray
Copy link
Owner

rjray commented Jun 16, 2011

I'm going to merge this, but I'm going to follow it up with undoing the change to t/41_server_hang.t. This test is needed, as it checks for a specific bug.

rjray added a commit that referenced this pull request Jun 16, 2011
@rjray
Merge pull request #3 from yannk/master
c7dfbfc 
Expat parser subclass is protected against ext ent attack, libxml isn't
@rjray rjray merged commit c7dfbfc into rjray:master Jun 16, 2011
@yannk
Copy link
Contributor Author

yannk commented Jun 16, 2011

oops, it wasn't my intention to skip that test for everyone, just me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannk @rjray