-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible namespace clash with Hex.pm? #14
Comments
Okay, so I did the rename, and lo and behold, problem disappears. How do you want to handle this? There are probably quite a few people already using your library through a github reference in their mix deps, and it wouldn't be good to just break that. I could make you a collaborator on my renamed fork, and we could take it from there? Leave this repo as it is for backwards compatibility, maybe with a note that it's been renamed and deprecated? Let me know what you want to do. |
Yeah, I've been thinking quite a bit about this since elixir introduced Hex a while back, but hadn't yet had a firm reason to make the change yet as it hadn't yet been causing any widespread issues. I'm fine with the name change, and I'm not overly concerned with backwards compatibility since the Elixir community, is I think, somewhat used to breaking changes, and it wouldn't be an issue again going forward. I also like the Hexate name, so go ahead and send a pull request with your changes and I'll merge them in. I'm also happy to add you as a committer / maintainer to this repo (and a maintainer in the package def if you'd like to add that to your pull request.) Does that sound good to you? |
Also - maybe could leave a branch as is at this point in time, for anyone that really needed to continue to use the old name for some reason? |
Okay, merged that pull request in, added the pre-rename branch and updated the README. Either you should rename it, or elevate my permissions. |
Also, I think this issue is now resolved! |
👍 👍 👍 Looks like you already have 'full permissions' - I'm guessing rename and delete are the two things you can't add. Just renamed the repo though. Great work!! |
Excellent! Yeah, I think you need to be the repo's 'owner' to do those. |
I've been getting some very strange behaviour trying to use this package in my color library suranyami/cor.
Here are 2 consecutive runs of
mix test
with nothing else happening in between:When I run
iex -S mix
and runHex.encode(255.0, 2)
in my lib's directory, I get UndefinedFunctionError.When I run
iex -S mix
in the hex directory, it works as expected.On a whim, I added a
version
function that returned "XXX" directly intodeps/hex/lib/hex.ex
file locally in my repo. Recompiled, raniex -S mix
:I then re-ran
mix test
, got the above errors, then raniex -S mix
for a SECOND TIME, and this is what I get:Which just so happens to be the same as Hex.pm version, as shown by:
So, in summary:
I'm going to temporarily rename my fork to
hexate
, and see if this voodoo all goes away. If it does, it might be an idea to rename this?Either that, or dig deeper into what exactly is going on here.
This certainly raises some questions about namespaces in Elixir, too.
The text was updated successfully, but these errors were encountered: