Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safeRenderCompletion documentation #1164

Closed
Steffan-Ennis opened this issue Feb 4, 2019 · 1 comment
Closed

safeRenderCompletion documentation #1164

Steffan-Ennis opened this issue Feb 4, 2019 · 1 comment

Comments

@Steffan-Ennis
Copy link

Steffan-Ennis commented Feb 4, 2019

Prerequisites

  • [x ] I have read the documentation;
  • [x ] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description

Should document the purpose of the safeRenderCompletion prop

When onChange has been invoked it should invoke props.onChange with the formData taken from it's arguments. Instead if props.safeRenderCompletion !== true, props.onChange is invoked outside of the component.setState callback.

This creates issues because the state change may not have been resolved before props.onChange has been invoked.

@epicfaace
Copy link
Member

Merging this into #1197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants