Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liveOmit does not clear errors from "additionalProperties: false" until formData change #1507

Closed
3 tasks done
MatinF opened this issue Nov 11, 2019 · 3 comments
Closed
3 tasks done
Projects

Comments

@MatinF
Copy link

MatinF commented Nov 11, 2019

Prerequisites

Description

In 2.0.0 alpha, I aim to use omitExtraData and liveOmit to ensure that any "extra" fields that are not supposed to be included in my formData gets cleaned out.

This works as expected, except for errors related to additionalProperties: false settings. When this is enabled, the loading of formData with additional properties results in an editor error. This disappears on any change to the form and does not block the user from submitting.

The expected behavior would be for this scenario to result in no errors and that the liveOmit would immediately clear the additionalProperties induced error without the need for the user to update any fields.

Steps to Reproduce

See below playground link:
playground example

While not critical, this would be great to get resolved if it is indeed unintended.

Best,
Martin

@epicfaace
Copy link
Member

It seems like it's unintended. Did you also see this issue in 1.8.0?

@MatinF
Copy link
Author

MatinF commented Nov 13, 2019

In 1.8.0 I believe I had some other issues with the data omitting, so I’m not sure. The functionality works great in 2.0.0 so I think this may just be an edge case due to the additionalProperties induced error

@ValYouW
Copy link
Contributor

ValYouW commented Mar 8, 2020

May or may not be related, is it possible to "omitExtraData" on form load?

@epicfaace epicfaace added this to To do in V2 via automation Mar 9, 2020
@epicfaace epicfaace moved this from To do to Won't do in v2 in V2 Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
V2
  
Won't do in v2
Development

Successfully merging a pull request may close this issue.

5 participants