Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate @rjsf/utils package #1655

Closed
epicfaace opened this issue Mar 16, 2020 · 2 comments · Fixed by #1641
Closed

Create separate @rjsf/utils package #1655

epicfaace opened this issue Mar 16, 2020 · 2 comments · Fixed by #1641
Projects

Comments

@epicfaace
Copy link
Member

epicfaace commented Mar 16, 2020

Original comment:

I say we break out the utils package since it'll be better to maintain that way. If we need to make a path or minor to the utils package, in theory it shouldn't break anyones installs if they are using a ^ (i.e. "@rjsf/utils": "^X.X.X").

For the fields and widgets, they should probably just be exposed in the root index file still so you can import them like so:

import { ArrayField } from '@rjsf/core';`

We would just need to ensure tree shaking is set up correctly, that way they don't import everything from @rjsf/core.

Originally posted by @chanceaclark in #1642

@epicfaace
Copy link
Member Author

Fixed by #1641.

V2 automation moved this from To do to Done Apr 5, 2020
@epicfaace epicfaace reopened this Apr 5, 2020
V2 automation moved this from Done to In progress Apr 5, 2020
V2 automation moved this from In progress to Done Apr 6, 2020
@heath-freenome
Copy link
Member

Fixed in the v5 beta, see the 5.x migration guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
V2
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants