Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate TextField override widgets to minimize code duplication across several themes #2526

Closed
1 of 3 tasks
heath-freenome opened this issue Aug 27, 2021 · 2 comments
Closed
1 of 3 tasks

Comments

@heath-freenome
Copy link
Member

heath-freenome commented Aug 27, 2021

Prerequisites

Description

The bootstrap-4, fluent-ui and material-ui themes all override TextWidget for many of the other input based widgets (i.e. UrlWidget, EmailWidget, etc...). The antd and semantic themes could also use the exact same pattern for some of the input based widgets as well where the only difference in code is the type. The core implementation has a BaseInput which is used for exactly the same pattern in use by the other themes. It probably makes sense from a DRY code perspective to remove as much of the duplicate code and rely on the underlying core implementation where possible. This is a big refactor. I volunteer to take it on... one theme at a time until it is done.

Version

v3.x

@heath-freenome
Copy link
Member Author

@epicfaace Here is the issue

@heath-freenome
Copy link
Member Author

Fixed in the v5 beta, see the 5.x migration guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants