Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples not shown as suggestions in material-ui, antd, semantic-ui and fluent-ui #2557

Closed
1 task done
palle-k opened this issue Sep 21, 2021 · 3 comments
Closed
1 task done
Labels
feature Is a feature request

Comments

@palle-k
Copy link

palle-k commented Sep 21, 2021

Prerequisites

Fully reproducible example: Playground link

Description

When selecting a theme other than default or bootstrap-4, field examples are not shown as suggestions.

Steps to Reproduce

  1. Create a JSON schema with examples for a field.
  2. Create a form (e.g. with @rjsf/antd) using the schema.
  3. Select the text field corresponding to the field with examples

Expected behavior

Examples should be shown like in the default theme or bootstrap-4

Actual behavior

Besides the default theme and bootstrap-4, no theme shows examples as suggestions.

Version

@rjsf/antd: 3.1.0
@rjsf/core: 3.1.0
antd: 4.16.13

@dwjohnston
Copy link
Contributor

Encountering this too.

Note also that the example in the default theme doesn't display properly (displays as [object Set]

Do the maintainers have an opinion about how examples should be displayed? (ie. in a popover, below the form element, etc). I'd be willing to possible submit a PR to add example functionality to default and mui widgets. (I think the helperText seems the appropriate place for examples).

Or is this something that really, we should just implement our own widgets to handle?

@epicfaace
Copy link
Member

@palle-k the playground link no longer seems to be working...

Do the maintainers have an opinion about how examples should be displayed?

Perhaps similar to how it looks like in the default theme and bootstrap-4?

@heath-freenome
Copy link
Member

Fixed in v5 beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is a feature request
Projects
None yet
Development

No branches or pull requests

5 participants