Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 theme does not add "for" attribute on labels #2875

Closed
4 tasks done
brockfanning opened this issue Jun 5, 2022 · 2 comments
Closed
4 tasks done

Bootstrap 4 theme does not add "for" attribute on labels #2875

brockfanning opened this issue Jun 5, 2022 · 2 comments
Assignees
Labels
bootstrap-4 bootstrap-4 related theme issue bug

Comments

@brockfanning
Copy link

Prerequisites

What theme are you using?

bootstrap-4

Version

4.2.0

Current Behavior

The labels for inputs don't have a "for" attribute.

Expected Behavior

The labels should have "for" attributes pointing to their inputs.

Steps To Reproduce

The see the issue, use the bootstrap-4 theme instead of the default. Here is a playground link demonstrating the issue.

By constrast, here is a link using the default theme that does not suffer from this problem.

Environment

(demonstrated with playground links)

Anything else?

No response

@brockfanning brockfanning added bug needs triage Initial label given, to be assigned correct labels and assigned labels Jun 5, 2022
@jacqueswho jacqueswho added bootstrap-4 bootstrap-4 related theme issue and removed needs triage Initial label given, to be assigned correct labels and assigned labels Jun 6, 2022
@heath-freenome
Copy link
Member

@brockfanning We have a skeleton crew here... are you comfortable providing a PR to fix this? If so, let's chat in the discord server about how to fix it in the upcoming v5 release

@heath-freenome
Copy link
Member

Fixed in the v5 beta, see the 5.x migration guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap-4 bootstrap-4 related theme issue bug
Projects
None yet
Development

No branches or pull requests

4 participants