Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number/integer upDown widget not working properly #2926

Closed
3 of 4 tasks
ElfeBc opened this issue Jul 13, 2022 · 2 comments
Closed
3 of 4 tasks

number/integer upDown widget not working properly #2926

ElfeBc opened this issue Jul 13, 2022 · 2 comments
Assignees
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned

Comments

@ElfeBc
Copy link

ElfeBc commented Jul 13, 2022

Prerequisites

What theme are you using?

material-ui

Version

4.2.0

Current Behavior

I've faced this in my code, but in the playground I saw that exist the same issue. When type is number or integer and instead of a number it contains a string, the value is removed from formData and when clicks on save there is no error.

Expected Behavior

If number/integer type field contains something that is not a number/integer, an error should be shown and data should not be removed.

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

Anything else?

No response

@ElfeBc ElfeBc added bug needs triage Initial label given, to be assigned correct labels and assigned labels Jul 13, 2022
@ElfeBc
Copy link
Author

ElfeBc commented Jul 15, 2022

I've continued investigating and for example in playground, if I remove from the ui schema to use the widget upDown for an integer it is velidated correctly, so seems that the issue comes from the upDown widget, not only for material ui, for all the the themes. Other thing is why it is needed to specify the updown widget for integer instead of having it by default like for numbers?

@ElfeBc ElfeBc changed the title number/integer validation not working number/integer upDown widget not working properly Jul 15, 2022
@heath-freenome
Copy link
Member

Fixed in the v5 beta, see the 5.x migration guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned
Projects
None yet
Development

No branches or pull requests

4 participants