Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codepen examples in docs broken #3215

Closed
epicfaace opened this issue Oct 29, 2022 · 4 comments · Fixed by #3371
Closed

codepen examples in docs broken #3215

epicfaace opened this issue Oct 29, 2022 · 4 comments · Fixed by #3371
Assignees
Labels

Comments

@epicfaace
Copy link
Member

See https://react-jsonschema-form.readthedocs.io/en/latest/usage/single/

Do you know what might have happened @heath-freenome @nickgros ?

@github-actions github-actions bot added the needs triage Initial label given, to be assigned correct labels and assigned label Oct 29, 2022
@heath-freenome
Copy link
Member

@epicfaace Can you be more specific about how they are broken? It's pretty clear we forgot to import the Form from @rjsf/core but the old links didn't either.

@heath-freenome heath-freenome added docs and removed needs triage Initial label given, to be assigned correct labels and assigned labels Dec 23, 2022
@epicfaace
Copy link
Member Author

Running into this issue (skypackjs/skypack-cdn#337) now.

@epicfaace
Copy link
Member Author

epicfaace commented Jan 8, 2023

@epicfaace Can you be more specific about how they are broken? It's pretty clear we forgot to import the Form from @rjsf/core but the old links didn't either.

By the way @heath-freenome , the reason they're broken now is that previously, we just used the UMD version and didn't need the import statements, as JSONSchemaForm was a global variable available by default. Now the code examples all use imports from different packages so we'll have to switch from using UMD to configuring codepen to also support js import statements.

@heath-freenome
Copy link
Member

By the way @heath-freenome , the reason they're broken now is that previously, we just used the UMD version and didn't need the import statements, as JSONSchemaForm was a global variable available by default. Now the code examples all use imports from different packages so we'll have to switch from using UMD to configuring codepen to also support js import statements.

@epicfaace is that an easy change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants