Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting source to TypeScript? #583

Closed
KurtPreston opened this issue May 18, 2017 · 15 comments
Closed

Converting source to TypeScript? #583

KurtPreston opened this issue May 18, 2017 · 15 comments

Comments

@KurtPreston
Copy link
Contributor

Would you consider a Pull Request converting react-jsonschema-form to TypeScript?

@zhang-ning
Copy link

+1 TypeScript

@glasserc
Copy link
Contributor

glasserc commented Jul 1, 2017

Not at the present time, although I guess that could change later. (If it does, I'll reopen.)

@glasserc glasserc closed this as completed Jul 1, 2017
@loganvolkers
Copy link
Contributor

@glasserc interesting discussions about the Jest typescript migration https://news.ycombinator.com/item?id=18918038

@epicfaace
Copy link
Member

epicfaace commented Jan 22, 2019

I wouldn't mind, honestly, though it might be a large task to do so.

@epicfaace epicfaace reopened this Jan 22, 2019
@thijssteel
Copy link
Contributor

I'd be willing to help with this.
However, i suck at everything webpack and compiler related. If someone has time to get me started with that I believe a full conversion should be possible in a couple of days work.

@chanceaclark
Copy link
Contributor

This is the :dream:. Let me know if you need some help as well.

@sbusch
Copy link
Contributor

sbusch commented Sep 16, 2019

@epicfaace is this a goal for v2?

We are heavily using TypeScript and are currently maintaining a patched set of TS definitions to have some (quite inexact) type safety for our custom fields and widgets. A native TS implementation with good type coverage will be a huge step not only for us, but IMO for the project (stability, types as documentation, confidence when doing some refactorings, see my latest comment at #1286)

So I also offer my help for this migration, and support in case of problems.

@epicfaace
Copy link
Member

Yeah, let's make it a goal for v2. @sbusch could you send over whichever of your TS definitions might be helpful? I think starting with those as well as the DefinitelyTyped definitions would give us a good starting point with which to add the rest of the types needed.

@thijssteel
Copy link
Contributor

https://github.com/wix-incubator/as-typed

do you guys think this might be useful?

@epicfaace epicfaace added this to In progress in V2 Dec 1, 2019
@epicfaace epicfaace moved this from In progress to Won't do in v2 in V2 Mar 28, 2020
@jacqueswho
Copy link
Contributor

we could possibly use tsdx

@heath-freenome
Copy link
Member

heath-freenome commented Jul 22, 2022

An effort has begun to convert the @rjsf/core package to typescript in the upcoming v5 version. @KurtPreston would you like to assist?

@KurtPreston
Copy link
Contributor Author

@heath-freenome Nice! I am no longer using this project, but it's great to hear that the TypeScript conversion is underway.

@ksbrar
Copy link

ksbrar commented Aug 16, 2022

@heath-freenome If you're still looking for extra hands, would be interested in participating!

@heath-freenome
Copy link
Member

@ksbrar We've managed to complete the conversion of the core package to Typescript but would love help with the antd theme

@heath-freenome
Copy link
Member

We are 100% typescript in the 5.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
V2
  
Won't do in v2
Development

No branches or pull requests