-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document cookie access & upgrade supertest #36
Conversation
@ctavan, I think adding In any event, thanks for these! Overdue and much appreciated. |
Will move to peerDependencies since this should be more future proof. Would require a major version bump. |
a03d05b
to
1ccd46b
Compare
@rjz I've moved supertest into a I'd leave bumping the version up to you. We could of course use the opportunity of a major version bump to introduce the change documented in #27 as a new default behavior. If you want I can update that other PR to introduce that change before we do the major version bump. WDYT? |
Also add an installation note to the readme as this now requires to manually install supertest alongside supertest-session. The former dependencies * cookiejar * methods now come as transitive dependencies through supertest.
Use nyc instead of jasmine-node and only test in reasonably modern node.js versions in TravisCI.
1ccd46b
to
0460733
Compare
Oh and is there a particular reason you run coveralls only on master? (I removed the master restriction for one CI run, hence the report above) |
No good reason here (and thanks for all of the long-overdue updates!) |
Alright, these are merged and released in v4.0.0. Thanks again, @ctavan! |
Would be great to get an upgraded version of supertest-session.
I was also considering removing
supertest
as a dependency and instead declaring it as apeer-dependency
so that users ofsupertest-session
can decide on their own, which version of supertest to use.What do you think about that, @rjz ?