This repository has been archived by the owner on May 16, 2021. It is now read-only.
Ignore changing Accept-Encoding header, fixes #56 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkh
added a commit
that referenced
this pull request
Jan 3, 2014
Ignore changing Accept-Encoding header, fixes #56
This was referenced Aug 31, 2014
zzak
pushed a commit
that referenced
this pull request
Aug 12, 2016
Ignore changing Accept-Encoding header, fixes #56
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I've done the bare minimum changes to fix issue #56 when it comes to
<video>and<audio>tags -- removed tracking of the Accept-Encoding header.But as I stated in the thread on that issue, in my opinion this whole SessionHijacking protection is ill-advised, and I'd like to suggest removing it. It is trivial for an attacker to circumvent, and prone to other false positives in the future (there's no telling if a normally operating browser decides to prefer other languages for different URLs or different types of media). Also, browser are updated frequently and that changes the User-Agent string, effectively logging users out of any sites using this protection, even if the login isn't supposed to expire in months.