Always respect :type parameter for send_file. Fixes GH sinatra#42

rkh · Sep 1, 2010 · 0b032a0 · 0b032a0
1 parent 108162b
commit 0b032a0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/sinatra/base.rb b/lib/sinatra/base.rb
@@ -158,6 +158,7 @@ def send_file(path, opts={})
       last_modified stat.mtime
 
       content_type mime_type(opts[:type]) ||
+        opts[:type] ||
         mime_type(File.extname(path)) ||
         response['Content-Type'] ||
         'application/octet-stream'

diff --git a/test/helpers_test.rb b/test/helpers_test.rb
@@ -345,6 +345,18 @@ def send_file_app(opts={})
       assert_equal 'text/plain', response['Content-Type']
     end
 
+    it 'sets the Content-Type response header if type option is set to a file extesion' do
+      send_file_app :type => 'html'
+      get '/file.txt'
+      assert_equal 'text/html', response['Content-Type']
+    end
+
+    it 'sets the Content-Type response header if type option is set to a mime type' do
+      send_file_app :type => 'application/octet-stream'
+      get '/file.txt'
+      assert_equal 'application/octet-stream', response['Content-Type']
+    end
+
     it 'sets the Content-Length response header' do
       send_file_app
       get '/file.txt'