Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init image help text may be slightly incorrect #73

Closed
halr9000 opened this issue Feb 21, 2022 · 2 comments
Closed

Init image help text may be slightly incorrect #73

halr9000 opened this issue Feb 21, 2022 · 2 comments

Comments

@halr9000
Copy link

From this line, where it says random noise will be used if no init image -- is that correct? This seems to conflict with lower down where the default for init_noise is none.

@rkhamilton
Copy link
Owner

I THINK that line in the docs is correct, though I can see the confusion. This was my attempt to understand what the original algorithm did and explain it.

If you look at this else-block in engine.py you will see the code path followed when init_noise is none. It feeds a randomly generated tensor of appropriate dimensionality into a PyTorch routine one_hot to generate a seed which gets iterated on by the subsequent algorithm. So, in short, it starts from a random tensor defined in a particular way.

If you don't use the default, and instead use "pixels" then the algorithm synthesizes an actual init_image from random pixels using this function, and feeds that into the generator as if it were an init_image.

I haven't extensively tested both types of random noise initialization, and can't say why they are both in the codebase that I started from.

Let me know if that makes sense. If you can suggest a better way to explain the parameters I'd be happy to hear it.

@halr9000
Copy link
Author

Cool, thanks for the lesson, and yes that makes sense. Only improvement I can think of would be to go back to init_noise in the table, and say something about the default (whether you call it none or not) is...still noise. :D

I tried one vqgan project a few weeks back and it was really oddly inaccurate. I didn't find out the cause until I lowered save_every. Turned out it starts not with noise, but with a random imagenet image! And by random, I mean prompt could be "castle", and iteration 0-10 are clearly a dog or cat or etc. :D

TY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants