Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import structure is confusing #2

Open
rkingsbury opened this issue Feb 12, 2021 · 0 comments
Open

Import structure is confusing #2

rkingsbury opened this issue Feb 12, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@rkingsbury
Copy link
Owner

The current import structure makes it impossible to import the top-level module, which may cause confusion for users not accustomed to the from X import Y pattern.

import membrane_toolkit

and subsequently access the core functions. e.g.

membrane_toolkit.core.donnan_equilibrium()

fails with

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'membrane_toolkit' has no attribute 'core'

Consider revising the import structure and/or using namespace packages instead

@rkingsbury rkingsbury added the enhancement New feature or request label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant