Add: shallowEqual for setValue method

rkit · Jan 29, 2016 · fddad8e · fddad8e
1 parent 091eb98
commit fddad8e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/examples/src/components/Tags.js b/examples/src/components/Tags.js
@@ -1,6 +1,7 @@
 import React, { Component } from 'react';
 import Select2 from '../../../src/components/Select2';
 import '../../../css/select2.css';
+import $ from "jquery";
 
 export default class Tags extends Component {
   constructor(props) {
@@ -19,6 +20,9 @@ export default class Tags extends Component {
          multiple={true}
          data={['bug', 'feature', 'documents', 'discussion']}
          value={ value1 }
+         onChange={(e)=> {
+            this.setState({ value1: $(e.target).val() });
+         }}
          options={{
            placeholder: 'search by tags',
          }} />
@@ -35,6 +39,9 @@ export default class Tags extends Component {
           ]}
           defaultValue={ 1 }
           value={ value2 }
+          onChange={ (e)=> {
+            this.setState({ value2: +$(e.target).val() });
+          }}
           options={{
             placeholder: 'search by tags',
           }} />

diff --git a/src/components/Select2.js b/src/components/Select2.js
@@ -2,6 +2,7 @@ import React, { Component, PropTypes } from 'react';
 import ReactDOM from 'react-dom';
 import $ from 'jquery';
 import 'select2';
+import shallowEqual from "react/node_modules/fbjs/lib/shallowEqual";
 
 export default class Select2 extends Component {
   static propTypes = {
@@ -64,7 +65,8 @@ export default class Select2 extends Component {
   }
 
   setValue(value) {
-    if (this.el.val() !== value) {
+    const elVal = this.el.val();
+    if (!shallowEqual(elVal, value)) {
       this.el.val(value).trigger("change");
     }
   }