Some urgent changes to OnRecognizer for CommonBlockAcceptor to work w…

…ith new way of Responders doing things

TODO

@@ -1,6 +1,7 @@
 Botfly Todo List (by priority)
 ==============================
 * Have Bot.new and Bot#run instead of just #login that always runs
+* Write cucumber integration testes
 * Replace CommonBlockAcceptor responder chain array with ResponderChain object
 ** Spec & create ResponderChain class
 ** Have responder chain stop call first responder ONLY after reaching a match

lib/botfly/common_block_acceptor.rb

@@ -34,12 +34,26 @@ class OnRecognizer
       def initialize(obj); @obj = obj; end
 
       def method_missing(name,&block)
+        @type = name
         Botfly.logger.info("#{@obj.to_debug_s}: Bot#on")
-        klass = Botfly.const_get(@obj.class_prefix + name.to_s.split('_').map(&:capitalize).join + "Responder")
+
         (@obj.responders[name] ||= []) << responder = klass.new(@obj, &block)
         Botfly.logger.info("#{@obj.to_debug_s}: #{@obj.class_prefix}#{name.to_s.capitalize}Responder added to responder chain")
         return responder
       end
+
+      private
+      def klass
+        begin
+          klass = Botfly.const_get(@obj.class_prefix + @type.to_s.split('_').map(&:capitalize).join + "Responder")
+        rescue
+          if @obj.class_prefix.empty?
+            klass = Responder
+          else
+            klass = Botfly.const_get(@obj.class_prefix+"Responder")
+          end
+        end
+      end
     end
 
     def class_prefix; ''; end

spec/botfly/common_block_acceptor_spec.rb

@@ -52,7 +52,7 @@ class FooResponder; def initialize(bar); end; end
       class FooBarResponder; def initialize(baz);end; end
     end
 
-    it "should instanciate responder based on name" do
+    it "should instanciate specialized responder based on name if class exists" do
       FooResponder.should_receive(:new)
       on.foo
     end
@@ -65,7 +65,7 @@ class FooBarResponder; def initialize(baz);end; end
     it "should add class prefix to front of responder class" do
       acceptor.stub(:class_prefix).and_return('Foo')
       Botfly.should_receive(:const_get).with('FooBarResponder').and_return(FooBarResponder)
-      on.bar
+      on.bar.should be_a_kind_of FooBarResponder
     end
 
     it "should add responder to object's responder chain hash" do
@@ -80,6 +80,17 @@ class FooBarResponder; def initialize(baz);end; end
       FooResponder.stub(:new).and_return(:foo_instance)
       on.foo.should be :foo_instance
     end
+
+    it "should default to Responder for basic responder" do
+      Responder.stub(:new).and_return(:plain)
+      on.baz.should be :plain
+    end
+
+    it "should still add class prefix even if special responder not found" do
+      acceptor.stub(:class_prefix).and_return('Foo')
+      FooResponder.stub(:new).and_return(:plain)
+      on.baz.should be :plain
+    end
   end
 end