fix(activity): incorrect this usage in onoff capability

DeviceDataId was read from `this` variable, which in that specific closure is undefined. By specifying the DeviceDataId as a `const` hit issue was resolved.
rkokkelk · Feb 26, 2023 · f1c0639 · f1c0639
1 parent 145562a
commit f1c0639
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/drivers/harmony_activity_driver/device.js b/drivers/harmony_activity_driver/device.js
@@ -41,15 +41,15 @@ class HarmonyActivity extends Homey.Device {
         });
 
         this.registerCapabilityListener('onoff', async (turnon, opts) => {
-            console.log(`ON/OFF triggered on ${this._deviceData.label}`);
-            const foundHub = this.hub;
+            const deviceDataId = this._deviceData.id;
+            console.log(`ON/OFF triggered on ${this._deviceData.label}(${deviceDataId})`);
 
-            if (foundHub === undefined)
+            if (this.hub === undefined)
                 return;
 
-            hubManager.connectToHub(foundHub.ip).then((hub) => {
+            hubManager.connectToHub(this.hub.ip).then((hub) => {
                 if (turnon)
-                    hub.startActivity(this._deviceData.id).catch((err) => {
+                    hub.startActivity(deviceDataId).catch((err) => {
                         console.log(err);
                         return Promise.reject(err);
                     });