🔥 Only need overwrite for authors file

rkotze · Dec 28, 2023 · b264a38 · b264a38
1 parent 0e1697b
commit b264a38
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 25 deletions.
diff --git a/packages/git-mob-core/src/git-mob-api/git-authors/create-coauthors-file.spec.ts b/packages/git-mob-core/src/git-mob-api/git-authors/create-coauthors-file.spec.ts
@@ -28,7 +28,7 @@ test('Save coauthor file in home directory', async () => {
   mockGitAuthors.mockReturnValue(mockGitAuthorsObject);
 
   await expect(createCoAuthorsFile()).resolves.toEqual(true);
-  expect(mockGitAuthorsObject.write).toHaveBeenCalled();
+  expect(mockGitAuthorsObject.overwrite).toHaveBeenCalled();
 });
 
 test('Save coauthor file with defined coauthor list', async () => {
@@ -49,7 +49,7 @@ test('Save coauthor file with defined coauthor list', async () => {
     createCoAuthorsFile([new Author('rk', 'rich kid', 'richkid@gmail.com')])
   ).resolves.toEqual(true);
 
-  expect(mockGitAuthorsObject.write).toHaveBeenCalledWith({
+  expect(mockGitAuthorsObject.overwrite).toHaveBeenCalledWith({
     coauthors: expectAuthor,
   });
 });
diff --git a/packages/git-mob-core/src/git-mob-api/git-authors/create-coauthors-file.ts b/packages/git-mob-core/src/git-mob-api/git-authors/create-coauthors-file.ts
@@ -23,9 +23,9 @@ export async function createCoAuthorsFile(authorList: Author[]): Promise<boolean
       string,
       Record<string, { name: string; email: string }>
     >;
-    await authorOps.write(schema);
+    await authorOps.overwrite(schema);
   } else {
-    await authorOps.write(coAuthorSchema);
+    await authorOps.overwrite(coAuthorSchema);
   }
 
   return true;

diff --git a/packages/git-mob-core/src/git-mob-api/git-authors/index.js b/packages/git-mob-core/src/git-mob-api/git-authors/index.js
@@ -15,15 +15,6 @@ export function gitAuthors(readFilePromise, writeFilePromise, overwriteFilePromi
     }
   }
 
-  async function writeToFile(path, content) {
-    const writeToPromise = writeFilePromise || promisify(fs.appendFile);
-    try {
-      return await writeToPromise(path, content, 'utf8');
-    } catch (error) {
-      throw new Error(error.message);
-    }
-  }
-
   async function overwriteFile(path, content) {
     const overwritePromise = overwriteFilePromise || promisify(fs.writeFile);
     try {
@@ -43,17 +34,6 @@ export function gitAuthors(readFilePromise, writeFilePromise, overwriteFilePromi
       }
     },
 
-    write: async authorJson => {
-      try {
-        return writeToFile(
-          await pathToCoAuthors(),
-          JSON.stringify(authorJson, null, 2)
-        );
-      } catch (error) {
-        throw new Error('Invalid JSON ' + error.message);
-      }
-    },
-
     overwrite: async authorJson => {
       try {
         return overwriteFile(

diff --git a/packages/git-mob-core/src/test-helpers/author-mocks.ts b/packages/git-mob-core/src/test-helpers/author-mocks.ts
@@ -23,7 +23,6 @@ export function mockGitAuthors(keys: string[]) {
   const coAuthors = buildCoAuthorObject(keys);
   return {
     read: jest.fn(async () => coAuthors),
-    write: jest.fn(async () => ''),
     overwrite: jest.fn(async () => ''),
     coAuthors: jest.fn(() => []),
     author: jest.fn(() => ({})),