config changes for stage0 and stage1

[krnowak]

There is a desire to pass some user configuration to stage1 (to configure a custom path to network plugins) and there was a proposal to add new fields to an already existing config (#1992) . I don't like the idea of mixing configuration for stage0 and stage1. So my idea is to move stage0 config to {/usr/lib/rkt,/etc/rkt}/config. Stage1 config would be in {/usr/lib/rkt,/etc/rkt}/stage1-config. That would work nicely with the default stage1 images directory added in #1977, which defaults to /usr/lib/rkt/stage1-images, so this path wouldn't clash with configuration stuff.

The config in /etc/rkt/config would have everything we stored in /etc/rkt so far. Config in /etc/rkt/stage1-config could contain configuration for location of network plugins and for the network itself.

This is a break, so it would be nice to land this before 1.0.

[iaguis]

This makes sense to me.

The config in /etc/rkt/config would have everything we stored in /etc/rkt so far. Config in /etc/rkt/stage1-config could contain configuration for location of network plugins and for the network itself.

So /etc/rkt/net.dwould be moved to /etc/rkt/stage1-config/net.d?

[krnowak]

Yeah, but the config in net.d is also another story. It does not follow the "kind and version" convention, so it might be harder here to add some new versions there. Unless we convert this somehow.

And the "The config in /etc/rkt/config would have everything we stored in /etc/rkt" is probably too much - we also have this trustedkeys directory there, which is hardly a config for me. Not sure what I would do with it, probably leave it as is.

[yifan-gu]

As discussed in today's sync. We need to make the net dir and plugin binary dir configurable.
Ref kubernetes/kubernetes#21047 (comment)

[yifan-gu]

@krnowak Does this have to block #1992 ? Do you think we can get that in first ?

[krnowak]

Here is the preliminary PR that implements the feature - #2312