Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

[WorkInProgress] Add config for network plugin directory #1992

Closed
wants to merge 1 commit into from

Conversation

tomdee
Copy link
Contributor

@tomdee tomdee commented Jan 19, 2016

Supersedes #1950

@jonboulle
Copy link
Contributor

/cc @krnowak

@krnowak
Copy link
Collaborator

krnowak commented Jan 21, 2016

It is more or less the step in the correct way, but there are several issues:

  • I don't like the mixing of the configuration for stage0 and stage1. See config changes for stage0 and stage1 #2013 for ideas.
  • Importing github.com/coreos/rkt/rkt will not work as intended, because
    • it is a "main" package, and importing "main" packages started to fail in go 1.5.
    • code in github.com/coreos/rkt/rkt largely belongs to the rkt binary, and the "networking/net_plugin.go" code is invoked in a different binary (init from the stage1 image), so init will not get the overridden configuration paths.

My plan is to split the rkt config stuff into general config stuff and then stage0 config and stage1 config.

@yifan-gu
Copy link
Contributor

yifan-gu commented Mar 3, 2016

Re @krnowak
As #2013 is a breaking change, it probably won't get in very soon. However, without the ability to specify the net dir and plugin dir, it makes rktnetes a hard time to use the net config and plugins users provided to k8s. See https://github.com/kubernetes/kubernetes/blob/33ef7a93a40a361904ac68a252e92beed8d444ca/docs/admin/network-plugins.md#cni
So I wonder if we can get this in first for now?

@yifan-gu
Copy link
Contributor

yifan-gu commented Mar 3, 2016

Sorry I misread the PR. This seems to enable us configure the dir for the net plugin binaries. But we also need the ability to configure the dir for the net configs.

@krnowak
Copy link
Collaborator

krnowak commented Mar 14, 2016

@yifan-gu: #2013 was described as breaking change, but that was before 1.0 was released. Right now, this change would be backward-compatible, but the old directories would be deprecated.

@tomdee tomdee closed this Sep 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants