Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

api: add v1 API protobuf definition and generated codes. #1359

Merged
merged 2 commits into from Sep 29, 2015
Merged

api: add v1 API protobuf definition and generated codes. #1359

merged 2 commits into from Sep 29, 2015

Conversation

yifan-gu
Copy link
Contributor

@yifan-gu yifan-gu commented Sep 3, 2015

@yifan-gu yifan-gu force-pushed the api_support branch 7 times, most recently from 0a49fef to b62f66c Compare September 3, 2015 02:04
@yifan-gu
Copy link
Contributor Author

yifan-gu commented Sep 3, 2015

Major changes from the original proposal are:

  • Rename GetPodStatus to InspectPod
  • Remove PodStatus type, merge its fields into Pod type.

@yifan-gu
Copy link
Contributor Author

yifan-gu commented Sep 3, 2015

Related to #1193 #1208

Also cc our kubelet friends :) @yujuhong @dchen1107 @vishh

vishh
vishh reviewed Sep 3, 2015
View reviewed changes
api/v1/api.proto
// PodState defines the possible states of the pod.
enum PodState {
POD_STATE_UNDEFINED = 0;
POD_STATE_EMBRYO = 1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document the semantics of each of these states? I assume the kubelet will have to directly deal with these states.

@yifan-gu yifan-gu force-pushed the api_support branch 2 times, most recently from 94844fe to 61508ea Compare September 3, 2015 20:37
@yifan-gu
Copy link
Contributor Author

yifan-gu commented Sep 3, 2015

@vishh Added app state events and documented the pod states.

@yifan-gu yifan-gu mentioned this pull request Sep 3, 2015
Closed
15 tasks
@yifan-gu yifan-gu force-pushed the api_support branch 3 times, most recently from 89ccc65 to 03e77c5 Compare September 4, 2015 17:48
@yifan-gu
Copy link
Contributor Author

yifan-gu commented Sep 4, 2015

Added two more rpc:

  • AddEvent which will be invoked by rkt pod to add events into the event list.
  • GetLogs which will fetch the logs of the pods and apps.

@yifan-gu yifan-gu force-pushed the api_support branch 5 times, most recently from db0b2f3 to 316d2f2 Compare September 8, 2015 18:57
@yifan-gu
Copy link
Contributor Author

yifan-gu commented Sep 8, 2015

Updated the Pod type: removed name, added manifest.
Also added annotations in PodFilter and ImageFilter so that user can use this as label selectors like in k8s' replication controller and service.

@yifan-gu yifan-gu force-pushed the api_support branch 4 times, most recently from ed33f6f to d8698d7 Compare September 9, 2015 00:37
@yifan-gu yifan-gu mentioned this pull request Sep 16, 2015
Closed
5 tasks
@yifan-gu yifan-gu force-pushed the api_support branch 4 times, most recently from 8e1f75a to 9a60275 Compare September 22, 2015 23:49
@yifan-gu
Copy link
Contributor Author

@jonboulle I implemented all the intefaces in the my api_service branch. Seems it's time to get those merged one by one now. We can start from this one

@jonboulle jonboulle mentioned this pull request Sep 24, 2015
Open
@yifan-gu
Copy link
Contributor Author

Anyone wants to give a lgtm? @jonboulle @iaguis @alban

@jonboulle
Copy link
Contributor

@yifan-gu could you send an email to rkt-dev asking for feedback?

@yifan-gu yifan-gu force-pushed the api_support branch 3 times, most recently from 8213b21 to 965e595 Compare September 25, 2015 00:50
alban
alban reviewed Sep 25, 2015
View reviewed changes
api/v1/api.pb.go
@@ -0,0 +1,988 @@
// Code generated by protoc-gen-go.
// source: api.proto
// DO NOT EDIT!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a generated file, shouldn't it be removed from the git repository and add calls to protoc-gen-go in some makefiles?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably needed by apps that want to build against it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@yifan-gu
Copy link
Contributor Author

Addressed @alban 's comments. Wonder if @thockin is interested in this and will be glad to hear some feedback :)

@yifan-gu
Copy link
Contributor Author

Will merge after CI green if no more objections

@jonboulle
Copy link
Contributor

As discussed oob please mark this clearly as alpha and document that it is
experimental and should not be used
On Sep 28, 2015 11:40 AM, "Yifan Gu" notifications@github.com wrote:

Will merge after CI green if no more objections

—
Reply to this email directly or view it on GitHub
#1359 (comment).

@yifan-gu
Copy link
Contributor Author

As discussed oob please mark this clearly as alpha and document that it is
experimental and should not be used

Marked in the .proto file here:
yifan-gu@28968f5#diff-1f6fbc35b4762277484db51a76548ad5R16

@yifan-gu yifan-gu force-pushed the api_support branch 2 times, most recently from 8e4c773 to b9c7fc6 Compare September 28, 2015 21:00
yifan-gu added a commit that referenced this pull request Sep 29, 2015
@yifan-gu
Merge pull request #1359 from yifan-gu/api_support
a609b37 
api: add v1 API protobuf definition and generated codes.
@yifan-gu yifan-gu merged commit a609b37 into rkt:master Sep 29, 2015
@yifan-gu yifan-gu deleted the api_support branch September 29, 2015 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
component/api server kind/design kind/enhancement needs/review
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yifan-gu @jonboulle @alban @iaguis @xiang90 @vishh