[kvm] Macvlan network type #1364
Conversation
|
@steveej review please? |
|
My opinion is that we should start moving the KVM networking code to CNI. As I understand that has been the intention all along and we should not procrastinate it further. |
|
After investigating the current situation and possible short-midterm changes in CNI, I revoke my last comment and will support the current situation in rkt. The code is isolated enough to be refactored out once we've figured out the destination. |
|
I've been able to reproduce the functional test failure locally after pulling your PR. I tracked the error down to the commit that updates the netlink library, it's definitely not the kvm related code that's causing failure here. I'll investigate this issue separately, until then this can't be merged. |
|
Diff in netlink library is quite big, vishvananda/netlink@ae3e7db...master |
jellonek
force-pushed
the
networking
branch
from
1fbcb6e
to
88bda50
Compare
|
|
steveej
added
depends-on/external
depends-on/cni
and removed
depends-on/external
labels
|
netlink has been bumped in master. The netlink bump commit has to be removed from this PR before rebasing it into master, but then semaphore should turn green :-) |
|
@jellonek can you please rebase? |
|
Yes, I will, but we have other problem with networking on kvm on which I'm currently working. |
OK. Thanks! |
jellonek
force-pushed
the
networking
branch
from
88bda50
to
02d51cf
Compare
|
Ups, should be rebased, bridge branch sneaked in non intentionally. |
jellonek
force-pushed
the
networking
branch
from
02d51cf
to
44fc55d
Compare
|
Based on #1303 |
|
Broken build.. please rebase |
|
ping? |
|
This have to wait a while. My priorities for now are networking fix (#1530) and then flannel support. In a meanwhile of tests I'll back to macvlan support and entering cleanup. |
| @@ -368,6 +447,16 @@ func (an activeNet) GuestIP() net.IP { | |||
| return an.runtime.IP | |||
| } | |||
| func (an activeNet) IfName() string { | |||
| if an.conf.Type == "macvlan" { | |||
| // macvtap device passed as parameter to lkvm binary have different | |||
| // kind of name, path to /dev/tunN made with N as link index | |||
On kvm flavor - macvlan is supported through macvtap interface.
|
LGTM now |
This PR adds macvlan network type CNI interface in kvm flavor with use of macvtap interfaces.