This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage0: don't change the group ownership of rootfs #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the group of the rootfs to 'rkt' causes problems with user namespaces when the group is not mapped in the user namespace. It prevents the container from doing a 'mkdir' or a 'lstat' on /proc. See systemd/systemd#1585 Setting the group ownership of the rootfs to 'rkt' was done in rkt#1452 so that the command 'rkt status' could work as non-root. However, if the rootfs is r-x for others, setting the group should not be necessary. r-x for others was removed by rkt#1607 but I am adding it back. This patch reverts a part of rkt#1602, therefore fixing the regression with user namespaces. 'rkt status' as non-root still works. Fixes rkt#1602
alban
force-pushed
the
alban/no-rkt-chown-on-rootfs
branch
from
3ea152d
to
8648af3
Compare
|
LFAD. |
krnowak
added a commit
that referenced
this pull request
Oct 21, 2015
stage0: don't change the group ownership of rootfs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the group of the rootfs to 'rkt' causes problems with user
namespaces when the group is not mapped in the user namespace. It
prevents the container from doing a 'mkdir' or a 'lstat' on /proc. See
systemd/systemd#1585
Setting the group ownership of the rootfs to 'rkt' was done in
#1452 so that the command 'rkt status'
could work as non-root. However, if the rootfs is r-x for others, setting
the group should not be necessary. r-x for others was removed by
#1607 but I am adding it back.
This patch reverts a part of #1602,
therefore fixing the regression with user namespaces. 'rkt status' as
non-root still works.
Fixes #1602
/cc @yifan-gu @krnowak