This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
rkt: gc command #302
Merged
rkt: gc command #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @vcaputo any thoughts on the interface changes? |
This was referenced Dec 23, 2014
Closed
Add a simple package to facilitate placing an flock on directories. This will be use to coordinate state between running containers and rkt status/gc tools.
Container directories deemed inactive by exclusive lock acquisition are atomically renamed to /var/lib/rkt/garbage, the directory's ctime gets updated as part of the rename. The /var/lib/rkt/garbage directory is then scanned for directories having a ctime older than --grace-period (defaults to 30m). Qualifying directories are deleted under another exclusive lock. All lock acquisitions are non-blocking with failures being ignored. Functions like gc status will have the grace period window for retrieving statuses from inactive containers in either the containers or garbage dirs, and should access the status files under the protection of a shared lock. Examples: Container "a983198b-79e3-432e-ad31-f105e96aa003" has recently exited: $ bin/rkt gc Moving container "a983198b-79e3-432e-ad31-f105e96aa003" to garbage $ Immediate subsequent gc finds nothing to do: $ bin/rkt gc $ Immediate subsequent gc force-discard by setting grace period to 0: $ bin/rkt gc --grace-period=0 Garbage collecting container "a983198b-79e3-432e-ad31-f105e96aa003" $
This moves to a very basic DirLock interface (which represents only an active lock), and functions to create the respective lock types (TryExclusiveLock, TrySharedLock, ...) instead of methods.
|
I'm going to merge this, we can revisit the lock interface and atomic conversions as the need arises (it might fall out of the keystore work) |
|
yay |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #266