Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

stage1: ensure systemd-tmpfiles is available in pod #3439

Merged
merged 3 commits into from Dec 2, 2016

Conversation

lucab
Copy link
Member

@lucab lucab commented Dec 2, 2016

TestAppSandboxSmoke is currently failing on host and src flavors because:

  • stage1-host is missing a /bin directory
  • stage1-host doesn't install systemd-tmpfiles from host
  • stage1-src is built without systemd-tmpfiles

This should fix testsuite failures on those flavors.

@lucab
Copy link
Member Author

lucab commented Dec 2, 2016

This also addresses #3424 (comment).

/cc @evverx

Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green 👍

@s-urbaniak
Copy link
Contributor

rekicked CI due to flakiness

@euank euank merged commit f5e1238 into rkt:master Dec 2, 2016
@evverx
Copy link
Contributor

evverx commented Dec 2, 2016

@lucab, thanks!
The TestFetchFromFile hangs:

25074 ?        Ss     0:08 tmux
25075 pts/1    Ss     0:00  \_ -bash
21617 pts/1    S+     0:02  |   \_ make functional-check
22942 pts/1    S+     0:00  |   |   \_ /usr/bin/bash -c set -e; \ printf '  %-12s %s\n' 'GO TEST' "github.com/coreos/rkt/tests"; \ sudo RKT_STAGE1_DEFAULT_FLAVOR="src" \ ?RKT="/home/vagrant/rkt-gopath/src
22943 pts/1    S+     0:00  |   |       \_ sudo RKT_STAGE1_DEFAULT_FLAVOR=src RKT=/home/vagrant/rkt-gopath/src/github.com/coreos/rkt/build-rkt-1.20.0+git/tmp/functional/rkt ACTOOL=/home/vagrant/rkt-gopath
22944 pts/1    Sl+    0:00  |   |           \_ /usr/bin/go test -tags src -timeout 60m -v github.com/coreos/rkt/tests
23338 pts/1    Sl+    0:07  |   |               \_ /tmp/go-build197934847/github.com/coreos/rkt/tests/_test/tests.test -test.timeout=60m -test.v=true
20211 pts/15   Ss+    0:04  |   |                   \_ stage1/rootfs/lib64/ld-linux-x86-64.so.2 stage1/rootfs/usr/bin/systemd-nspawn --boot --notify-ready=yes -Zsystem_u:system_r:svirt_lxc_net_t:s0:c8,c35

$ sudo strace -p 20211 -yy -s 500 -v
strace: Process 20211 attached
writev(2</dev/pts/15>, [{iov_base="Container rkt-7c124d22-c6ce-415e-a61b-3a83e648a94a exited successfully.", iov_len=71}, {iov_base="\n", iov_len=1}], 2^Cstrace: Process 20211 detached
 <detached ...>

But seems like that's unrelated to this PR

@lucab
Copy link
Member Author

lucab commented Dec 2, 2016

@evverx yes, it is an unrelated problem (exacerbated by some recent increase in debug output). See #3443 for a fix and explanation. Which environment are you using for running the testsuite? Can you check if you spot any other hanging tests?

@evverx
Copy link
Contributor

evverx commented Dec 3, 2016

Which environment are you using for running the testsuite?

           Chassis: vm
    Virtualization: oracle
  Operating System: Fedora 24 (Cloud Edition)
       CPE OS Name: cpe:/o:fedoraproject:fedora:24
            Kernel: Linux 4.8.10-200.fc24.x86_64
      Architecture: x86-64
$ ./build-rkt-1.20.0+git/target/bin/rkt version
rkt Version: 1.20.0+gitf5e1238
appc Version: 0.8.9
Go Version: go1.7.4
Go OS/Arch: linux/amd64
Features: +TPM +SDJOURNAL

Can you check if you spot any other hanging tests?

My last attempt was successful (all tests passed).

See #3443 for a fix and explanation

I'll take a look. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants