Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

vendor: bump gexpect to 0.1.1 #3467

Merged
merged 2 commits into from Dec 12, 2016
Merged

Conversation

lucab
Copy link
Member

@lucab lucab commented Dec 9, 2016

This changes Expect() to not return early errors
on final reads (EOF but n != 0) in order to avoid discarding
the last bytes from the source buffer. According to Reader interface
next loop iteration will get a (0, EOF) causing this method to
return.

Supersedes #3442

@s-urbaniak s-urbaniak added this to the v1.22.0 milestone Dec 9, 2016
Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-urbaniak s-urbaniak merged commit d223553 into rkt:master Dec 12, 2016
@lucab lucab mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants