Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

config: add tests for a couple documented configs #3931

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

euank
Copy link
Member

@euank euank commented May 25, 2018

These tests additions were prompted by issue #3916.

Ideally all documented configs would be included here (possibly via living outside of the docs and having the copy in the docs be templated in or such).

euank added 4 commits May 25, 2018 14:36
This tests that a small number of the documented configurations
suggested can in fact unmarshal without error.
The Golang team only officially supports the two most recent major
versions.
At the very least, we can safely drop 1.6.x and add 1.10.x
@euank
Copy link
Member Author

euank commented Jun 1, 2018

Semaphore appears to be flaking on a networking issue unrelated to this pr:

Output: "gc: moving pod \"94616432-4eb6-4fed-a406-0be0e936125c\" to garbage
Garbage collecting pod \"94616432-4eb6-4fed-a406-0be0e936125c\"
stage0: Execing [/tmp/datadir-967761143/pods/exited-garbage/94616432-4eb6-4fed-a406-0be0e936125c/stage1/rootfs/gc --debug --local-config /tmp/localdir-160387050 94616432-4eb6-4fed-a406-0be0e936125c]
stage1 gc: Removing journal link.
stage1 gc: Cleaning up cgroups.
stage1 gc: Tearing down networks.
networking: error on removing masquerading
  └─exit status 1: iptables: No chain/target/match by that name.
"

Sounds like an nftables kernel module is missing?

@lucab
Copy link
Member

lucab commented Jun 1, 2018

@euank is that a single flake or does it persist across retries?

@euank
Copy link
Member Author

euank commented Jun 1, 2018

I've seen it twice in a row now. I don't have permissions on the rkt semaphore to poke around too much though.

In go 1.10, 'go vet' complains about unkeyed fields. This makes go vet
happy.
@lucab
Copy link
Member

lucab commented Jun 1, 2018

@euank it looks like you were missing from the semaphore team, added you now.

Before, the contents of the error were lost in that path.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants