Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend spec #23

Merged
merged 28 commits into from
Mar 17, 2021
Merged

Extend spec #23

merged 28 commits into from
Mar 17, 2021

Conversation

rktjmp
Copy link
Owner

@rktjmp rktjmp commented Mar 14, 2021

No description provided.

@rktjmp rktjmp marked this pull request as ready for review March 14, 2021 14:23
@rktjmp
Copy link
Owner Author

rktjmp commented Mar 14, 2021

RFC on docs if possible, @savq @kunzaatko

@rktjmp
Copy link
Owner Author

rktjmp commented Mar 14, 2021

Better link I think: https://github.com/rktjmp/lush.nvim/pull/23/files#diff-0aeed55bea344e264dccb1c6b15c1a0adbd2461f98e072b7663a6ad486254999R325

diff seems more readable than I thought it would be.

doc/lush.txt Outdated Show resolved Hide resolved
doc/lush.txt Outdated Show resolved Hide resolved
doc/lush.txt Outdated Show resolved Hide resolved
doc/lush.txt Outdated Show resolved Hide resolved
doc/lush.txt Outdated Show resolved Hide resolved
doc/lush.txt Outdated Show resolved Hide resolved
@savq
Copy link
Contributor

savq commented Mar 15, 2021

  • I like the explicit mention of potential use cases.

  • Also good to mention the precedence rules.

  • Remember to add the new section in the TOC.

  • The other stuff is more formatting specific, I'll make a commit for that.

@rktjmp
Copy link
Owner Author

rktjmp commented Mar 15, 2021

Ya, added to TOC already. Make sure youre looking at the latest version, I had an old link in the initial post.

doc/lush.txt Outdated Show resolved Hide resolved
doc/lush.txt Outdated Show resolved Hide resolved
@savq
Copy link
Contributor

savq commented Mar 15, 2021

Made #25. Most changes are fixing typos and adding capitals. I only changed a couple sentences.

@rktjmp rktjmp merged commit 9c0bb04 into main Mar 17, 2021
@github-pages github-pages bot temporarily deployed to github-pages March 17, 2021 05:59 Inactive
@rktjmp rktjmp deleted the extend-spec branch April 9, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants