Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
9 changed files
with
228 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # Necromancy | ||
|
|
||
| Using Phoenix.LiveView inplace of classical controllers, optionally | ||
| resurrecting them from the dead. | ||
|
|
||
| ## Reasoning | ||
|
|
||
| - A consistent developer experience. | ||
|
|
||
| All your views are constructed in the same manner, with a mount, handle_params, | ||
| etc process flow. The "template render flow" is the same. | ||
|
|
||
| - But not all views really need to be "live" | ||
|
|
||
| Some static [sic] pages have no sever state to update. These could/can just be | ||
| regular Phoenix controller actions. | ||
|
|
||
| - But, but some views might warrant starting dead and then *becoming* live. | ||
|
|
||
| ## Reasons against | ||
|
|
||
| - Kinda weird | ||
| - Added complexity with expecting a liveview to never connect? | ||
| - Phoenix 1.7 *may* unify how templates are put together with the new | ||
| templating engine? | ||
|
|
||
| ## Direct usecase | ||
|
|
||
| All pages show content, with a "live chat/form" pop-out. The live-chat should | ||
| integrate with the current page - it should not redirect. | ||
|
|
||
| ## Methods | ||
|
|
||
| - Show button, on click spawn iframe with liveview in it, let this do the fancy | ||
| work. | ||
| - Simpler, no hacks | ||
| - iframes ugly? | ||
|
|
||
| - Dead to live | ||
| - render view as dead-liveview, on click connect livesocket or import livesocket code |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| defmodule NecromancyWeb.NecroLive do | ||
| defmodule Form do | ||
| use Ecto.Schema | ||
|
|
||
| embedded_schema do | ||
| field(:name) | ||
| end | ||
|
|
||
| def changeset(params) do | ||
| %Form{} | ||
| |> Ecto.Changeset.cast(params, [:name]) | ||
| |> Ecto.Changeset.validate_required([:name]) | ||
| |> Ecto.Changeset.validate_format(:name, ~r/[0-9] [a-z]+/, | ||
| message: "Name must match 0-9 a-Z" | ||
| ) | ||
| end | ||
| end | ||
|
|
||
| use NecromancyWeb, :live_view | ||
|
|
||
| def mount(_params, _session, socket) do | ||
| socket = | ||
| assign( | ||
| socket, | ||
| event_ran?: false, | ||
| connected?: connected?(socket), | ||
| changeset: Form.changeset(%{}), | ||
| task: nil, | ||
| bytes: nil | ||
| ) | ||
|
|
||
| {:ok, socket} | ||
| end | ||
|
|
||
| def handle_event("start_process", _, socket) do | ||
| task = | ||
| Task.async(fn -> | ||
| Process.sleep(3000) | ||
| {:ok, :crypto.strong_rand_bytes(64)} | ||
| end) | ||
|
|
||
| socket = assign(socket, task: task) | ||
| {:noreply, socket} | ||
| end | ||
|
|
||
| # you can match on task ref if you have a reason to | ||
| def handle_info({ref, {:ok, bytes}}, %{assigns: %{task: %{ref: ref}}} = socket) do | ||
| socket = assign(socket, task: nil, bytes: bytes) | ||
| {:noreply, socket} | ||
| end | ||
|
|
||
| def handle_info({:DOWN, _ref, :process, _pid, _reason}, socket) do | ||
| # probably do something smart here | ||
| {:noreply, socket} | ||
| end | ||
|
|
||
| def handle_event("run_event", _, socket) do | ||
| socket = assign(socket, event_ran?: true) | ||
| {:noreply, socket} | ||
| end | ||
|
|
||
| def handle_event("validate", %{"form" => params}, socket) do | ||
| changeset = | ||
| Form.changeset(params) | ||
| |> Map.put(:action, :validate) | ||
|
|
||
| socket = assign(socket, changeset: changeset) | ||
| {:noreply, socket} | ||
| end | ||
|
|
||
| def handle_event("submit", %{"form" => params}, socket) do | ||
| changeset = | ||
| Form.changeset(params) | ||
| |> Map.put(:action, :validate) | ||
|
|
||
| socket = assign(socket, changeset: changeset) | ||
|
|
||
| socket = | ||
| case changeset do | ||
| %{valid?: true} -> | ||
| put_flash(socket, :info, "nice one!") | ||
|
|
||
| _ -> | ||
| put_flash(socket, :error, "dang it!") | ||
| end | ||
|
|
||
| {:noreply, socket} | ||
| end | ||
|
|
||
| def render(assigns) do | ||
| ~H""" | ||
| <section> | ||
| <p :if={@connected?}> | ||
| I am ALIVE. <button phx-click="start_process">Run long task</button> | ||
| <%= inspect(@task) %> | ||
| <%= inspect(@bytes) %> | ||
| </p> | ||
| <p :if={not @connected?}> | ||
| I am DEAD. | ||
| </p> | ||
| <p :if={not @connected?}> | ||
| <button type="button" data-connect-liveview="click">Just Connect</button> | ||
| </p> | ||
| <button type="button" phx-click="run_event"> | ||
| Run an action | ||
| </button> | ||
| <p>Event has been run?: <%= @event_ran? %></p> | ||
| Access form to connect | ||
| <.form | ||
| :let={f} | ||
| data-connect-liveview="input" | ||
| for={@changeset} | ||
| phx-change="validate" | ||
| phx-submit="submit" | ||
| phx-page-loading="false" | ||
| > | ||
| <%= text_input(f, :name) %> | ||
| <%= error_tag(f, :name) %> | ||
| </.form> | ||
| </section> | ||
| """ | ||
| end | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| defmodule NecromancyWeb.PageControllerTest do | ||
| use NecromancyWeb.ConnCase | ||
|
|
||
| test "GET /", %{conn: conn} do | ||
| conn = get(conn, "/") | ||
| assert html_response(conn, 200) =~ "Welcome to Phoenix!" | ||
| end | ||
| # test "GET /", %{conn: conn} do | ||
| # conn = get(conn, "/") | ||
| # assert html_response(conn, 200) =~ "Welcome to Phoenix!" | ||
| # end | ||
| end |