#113: Extending req/res mock to include send(), updating mocha for se…

…curity vulnerability

lib/framework/koa.js

@@ -108,17 +108,36 @@ function authenticate(passport, name, options, callback) {
       // mock the `req` object
       const req = createReqMock(ctx, options.assignProperty || passport._userProperty || 'user')
 
+      /*
+       * res.end & res.send should basically behave the same
+       * res.end only takes strings (but should be okay for the mock to take more)
+       * res.send can send a buffer, object, array, or string
+       */
+      function setBodyAndResolve(content) {
+        switch (typeof content) {
+          case 'Buffer':
+            ctx.body = content.toString()
+            break
+          case 'object':
+            ctx.body = JSON.stringify(content)
+            break
+          case 'string':
+          default:
+            ctx.body = content
+            break
+        }
+        resolve(false)
+      }
+
       // mock the `res` object
       const res = {
         redirect: function(url) {
           ctx.redirect(url)
           resolve(false)
         },
         setHeader: ctx.set.bind(ctx),
-        end: function(content) {
-          if (content) ctx.body = content
-          resolve(false)
-        },
+        end: setBodyAndResolve,
+        send: setBodyAndResolve,
         set statusCode(status) {
           ctx.status = status
         },
@@ -127,6 +146,8 @@ function authenticate(passport, name, options, callback) {
         }
       }
 
+      req.res = res
+
       // update the custom callback above
       if (callback) {
         callback.resolve = resolve

package.json

@@ -24,7 +24,7 @@
     "koa": "^2.3.0",
     "koa-bodyparser": "^4.2.0",
     "koa-route": "^3.2",
-    "mocha": "^3.5.0",
+    "mocha": "^5.1.1",
     "passport-local": "^1.0",
     "supertest": "^3.0"
   },