-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
req.session.regenerate is not a function #181
Comments
@rkusa : can you please downgrade ? This is really blocking me and I'm rethinking to switch to express if this is going to take a long time :/ |
@younes-io @haydarai Sole purpose of |
@rkusa koa-passport 5 uses passport v6 whereas koa-passport 4 uses passport v4. Since passport v5 seems to be the way to go for now, how does one handle that? |
@nemphys Fair point. Passport v5 looks to me like it just stops extending |
@rkusa right, this is doable, but I just realised that it beats my purpose to get rid of the passport < 0.6.0 vulnerability (which is the reason I wan to update koa-passport :-) ) |
Is there any ETA for this? I'm considering my options for what the best way would be to solve this problem within the next few weeks (waiting for a fix or refactoring) |
@rkusa |
Add dummy req.session.regenerate and req.session.save for passport 0.6.0
Only add dummy regenerate and save methods if they do not already exist
I've added a fix to |
I am contemplating whether I should merge #187 (add a workaround to |
@rkusa I suppose the 2nd option is better; merging something like that in koa-passport would just be an ugly fix, so anyone interested (including myself) should take the responsibility of adding it to the codebase. |
koa-session v6.4.0 was just released, with my PR linked above merged (koajs/session#221). This solves the issue without any workarounds needed. |
Nice! What about koa-generic-session? |
Perhaps the MR can serve as a scaffolding for the same change there? I don't use koa-generic-session, so won't have the time to look into it. |
"koa-passport": "^6.0.0", We get error: 2023-02-07T12:19:47.935Z error: uncaughtException: Cannot read properties of null (reading 'regenerate') Please help, how to fix that? |
@ilonaand the failing line of code is here:
So it looks like you don't have a session. Are you sure you're actually using the |
Thanks, but we using koa-session import session from 'koa-session'; passport.serializeUser((user: unknown, done) => { passport.deserializeUser((id: string, done) => { .use(session(Config, app)) The user logs in without errors, the session is created, and the error occurs immediately after logging out |
Very strange. We have a setup very similar to do this, and it all works for us. The error message does hint at |
* initial team model and stuff * a few team endpoints, teams discordcmd, refresh token functionality * update migration * ok i made all the team endpoints * npm run audit * update migration * mode ID filters for bws * fix build * discord commands and restructure db function locations * rename save to upload * test fixes * more fixes and add public folder * no support for gifs (yet) * more fixes and also better image cropping * more fixes, more discord cmds, create getTeamInvites * change team ava url to explicit api url due to proxy * ok 10 mb kinda ridiculous * extra security (dont use discord ID lookup), more test fixes * tournament registration cron * cron fixes * ease on cron queries * fix missing inv accept check + rewrite for loop * optimize discord invite q (and support actionRow limit) * use r2 for team avatars * feat: add base for osu irc bot (#208) * feat: add base for osu irc bot * fix: connection log typo * style: simplify self-message check * feat: add botAccount boolean * style: whitespace * feat: multiplayer commands, listen to channel message event * style: remove unnecessary parentheses * fix: placement of parentheses * feat: reduce command handler duplication * fix: whitespace * fix: more whitespace * Match Infrastructure (#207) * initial match model creation * initial match migration and models and routing * pickban order(maporder) entity * additional properties for match specs + update migration + change match name (sql reserved keyword) * remove discriminators in discord + errors * rename match to matchup everywhere * matchup generator endpoint (remove stages) * fix migration also add a first property * npm run lintfix * update readme for ircbot * intiial cron setup * add matchupGroup to models for qualis * feat: require a qualifier date when a team registers for a tournament with a qualifier stage (#211) * feat: require a qualifier date on team register if tourney has qualifiers, create matchup * fix: wtf * Auto-running Qualifiers (#213) * renaming irc to bancho * more bancho renaming * some pool check fixes for create/publish * Create match creation logic stuff * model + migration fixes * missing checks on slot map count * finish initial setup for auto-running qualifier * 🚑 ⬆️ Upgrade nodesu and bancho.js, fixing typings compilation (#214) * import osu bot * fixes to miscellaneous stuff + build * finish qualis bot * add missing leftjoin in register endpoint * more refbot fixes * change cron delay to 10 seconds * more fixes and also actually make the timers matter * check all players in lobby before running autostart * final fixes before i lose my mind refactoring * REFACTOR!!!!! * poon fixes * nicer log storage Yey * fix matchup running in cron-runner instead of bancho (+ dupe bancho client instances) * mod function fix * wrote wrong publicurl name in docker-compose.json * actually end match * remove unnecessary saves keep matchup save for match end * poon suggestion * Bancho Message Storage (#215) * matchupmessages model and migration * add matchupmessage logic to ref bot * testing * batch save and clear timer on end * date save --------- Co-authored-by: Hugo Denizart <thepoon@osufr.live> * update koa-session to circumvent koa-passport 6 issues rkusa/koa-passport#181 * fixes and refactors to osu apiv2 * add typing to badgefilter * annoying build fixes and mode type --------- Co-authored-by: James <tsunyoku@gmail.com> Co-authored-by: Hugo Denizart <thepoon@osufr.live>
It seems to be because of this jaredhanson/passport#907, probably a good idea to downgrade the passport version for now.
The text was updated successfully, but these errors were encountered: