Add from_raw_parts style interfaces to RelPtr and ArchivedBox
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:ohno: nightly compiler ICE-ing |
|
Marked ready for review since it seems to work for what I want it to in Not sure why it would cause the compiler to ICE.... I guess I'll just try rerunning and see if it was a fluke lol. |
|
Seems the ICE is the same on |
|
The relevant ICE was in theory fixed, so should be good to go now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed the need for this on Discord. Draft for now so I can prototype with it in
protossand make sure it works as expected/is necessary.Also snuck in a ignore
/tmpdirectory in.gitignore, a moderately common pattern which I use is to haverust-analyzercompile into a separate target directory so that it doesn't conflict with regular cargo builds.