-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PartialOrd between Option/ArchivedOption. #448
Conversation
Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
See #434, there are some issues with adding |
Do you want me to put this behind a feature flag as discussed on discord? Any preference for the name of the feature? |
I think a feature flag would be good. Maybe something like |
Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
I added the feature flag, but currently seems I can't test the code due to an (unrelated?) errors:
|
Sorry about that, the |
Not super urgent, if you plan to release 0.8 anyways soon I can wait. |
Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com> --------- Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com> --------- Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
* Implement PartialOrd between Option/ArchivedOption. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com> * Add feature flag. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com> --------- Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
This implements PartialOrd for comparing Option and ArchivedOption.