Implement CheckBytes on ArchivedOptionBox and ArchivedOptionNonZeroN, plus ArchivedOptionNonZeroN::take()
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to test the ArchivedOptionBox more. |
|
Is it okay to leave that test where it is or should I move it to I did have to reimplement it to bypass |
djkoloski
approved these changes
Mar 24, 2024
In the future I'd like to move the tests out of rkyv_test and back into the main codebase, so this is actually a step in the right direction. |
|
Should be good to go. You're welcome to squash this. |
|
Thanks for the PR! Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.
Closes #474
Closes #368
The
ArchivedOptionNonZeroN::take()is a bit extra, but I was in the file.