Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings' order in dataset docs are incorrect #95

Closed
nesnoj opened this issue May 30, 2023 · 2 comments · Fixed by #98
Closed

Headings' order in dataset docs are incorrect #95

nesnoj opened this issue May 30, 2023 · 2 comments · Fixed by #98
Labels
bug 🐞 Something isn't working documentation 📝 Improvements or additions to documentation low priority 🔽

Comments

@nesnoj
Copy link
Member

nesnoj commented May 30, 2023

See 2. in #92 (review)

@nesnoj nesnoj added bug 🐞 Something isn't working documentation 📝 Improvements or additions to documentation low priority 🔽 labels May 30, 2023
@dvdstrzl
Copy link
Collaborator

dvdstrzl commented Jun 5, 2023

I added the "#" intentionally, because:

"The TOC is not intended to list h1 elements. In HTML5 only one h1 is valid per page or article tag and the whole content is enclosed in an article tag, so adding multiple h1 is not considered valid. Only 2nd+ level items are listed. This is intended behavior. Also see squidfunk/mkdocs-material#654."
(squidfunk/mkdocs-material#818 (comment))

We could add a "#" via the script to every heading.

@dvdstrzl
Copy link
Collaborator

dvdstrzl commented Jun 5, 2023

@nesnoj nesnoj mentioned this issue Jun 9, 2023
3 tasks
@nesnoj nesnoj closed this as completed in #98 Jun 9, 2023
@dvdstrzl dvdstrzl linked a pull request Aug 29, 2023 that will close this issue
3 tasks
@dvdstrzl dvdstrzl removed a link to a pull request Aug 29, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working documentation 📝 Improvements or additions to documentation low priority 🔽
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants