Feature/max cap ii

[Piranias]

Continue on #237

Changes proposed in this pull request:
Add parameter "maximumCap" for

• transformers (energyConversion.csv)
• storages (e.g. storage_01.csv)

The following steps were realized, as well (if applies):

• Use in-line comments to explain your code
• Write docstrings to your code
• For new functionalities: Explain in readthedocs
• Write test(s) for your new patch of code
• Update the CHANGELOG.md
• Apply black (black . --exclude docs/)
• Check if tests pass

Please mark above checkboxes as following:

• Open
• Done

❌ Check not applicable to this PR

_{For more information on how to contribute check the CONTRIBUTING.md.}

[Piranias]

Also this way D1 would be simplified again because all sources would have the parameter.

I am not sure what you refer to as source, if you need feedback, can you quote the line here?

If all assets that call the functions: source_dispatchable_optimize() and source_non_dispatchable_optimize() have the parameter "maximumCap" then the distinction "if "maximumCap" in dict_asset" in D1 would be redundant. This way we could simplify D1 again.

For transformers and storages I added a line in C1 that creates the parameter with value "None" if it doesn't exist yet to avoid the distinction in D1.

So my question is: are there other assets (e.g. the DSO) that call the functions source_dispatchable_optimize() and source_non_dispatchable_optimize() that do not have the parameter "maxiumCap"?

[smartie2076]

Also this way D1 would be simplified again because all sources would have the parameter.

I am not sure what you refer to as source, if you need feedback, can you quote the line here?

If all assets that call the functions: source_dispatchable_optimize() and source_non_dispatchable_optimize() have the parameter "maximumCap" then the distinction "if "maximumCap" in dict_asset" in D1 would be redundant. This way we could simplify D1 again.

Ah yeah, we should do that when creating the next MVS release that solves the compability issue. If you do not integrate below solution, can you create an issue that reminds us of that task?

For transformers and storages I added a line in C1 that creates the parameter with value "None" if it doesn't exist yet to avoid the distinction in D1.

Beautiful way to go - if that is easily done for the sources as well (pr #237), you could do the same here. In that case you do not have to create above issue, as there is nothing to be reminded of! :)

So my question is: are there other assets (e.g. the DSO) that call the functions source_dispatchable_optimize() and source_non_dispatchable_optimize() that do not have the parameter "maxiumCap"?

Yes, actually, you need to add the default value for "maximumCap" in this function, and probably here.
That function creates imaginary sources for peak demand pricing of the DSOs. I would not put it into the DSOs csvs, as that info might be confused with the transformer stations that have to be defined in energyConversion.csv.

Please run following test data to check whether or not the peak demand pricing function still works after you change the code (this one uses monthly peak pricing):
inputs.zip

[Piranias]

Yes, actually, you need to add the default value for "maximumCap" in this function, and probably here.
That function creates imaginary sources for peak demand pricing of the DSOs. I would not put it into the DSOs csvs, as that info might be confused with the transformer stations that have to be defined in energyConversion.csv.

I added a line to "define_source()" that creates the maxiumumCap parameter with "None" value and adapted D1 accordingly. I found that the function"define_source()" is only used to create DSO sources. Therefore I would suggest to change its name to "define_dso_source()" instead. It's kind of confusing the way it is, because powerplants are sources too. Or is there other cases where this function would be used for other sources than the dso?

Please run following test data to check whether or not the peak demand pricing function still works after you change the code (this one uses monthly peak pricing):
inputs.zip

actually these inputs did not work for me. But the error has nothing to do with my changes as far as I understand. I get an error in this line.

I could look where it comes from if no one else is working on that (apparently the dictionary "dict_values["energyProviders"][dso]" is not created correctly. But that would be another issue.

[smartie2076]

I added a line to "define_source()" that creates the maxiumumCap parameter with "None" value and adapted D1 accordingly.

Good.

I found that the function"define_source()" is only used to create DSO sources. Therefore I would suggest to change its name to "define_dso_source()" instead. It's kind of confusing the way it is, because powerplants are sources too. Or is there other cases where this function would be used for other sources than the dso?

I think it should also be created for fuel source sinks, eg. diesel or water, which currently is not working (issue #186). I would therefore not rename it.

Please run following test data to check whether or not the peak demand pricing function still works after you change the code (this one uses monthly peak pricing):
inputs.zip

actually these inputs did not work for me. But the error has nothing to do with my changes as far as I understand. I get an error in this line.
I could look where it comes from if no one else is working on that (apparently the dictionary "dict_values["energyProviders"][dso]" is not created correctly. But that would be another issue.

Let me check this today, I am really surprised it does not work.

[smartie2076]

Ah, some csv editor misformatted the line with the peak demand pricing.

 "peak_demand_pricing_period,""times per year (1,2,3,4,6,12)"",12"

instead of

peak_demand_pricing_period,"times per year (1,2,3,4,6,12)",12

Here are the updated files:
inputs_updated.zip

[Piranias]

Ah, some csv editor misformatted the line with the peak demand pricing.

 "peak_demand_pricing_period,""times per year (1,2,3,4,6,12)"",12"

instead of

peak_demand_pricing_period,"times per year (1,2,3,4,6,12)",12

Here are the updated files:
inputs_updated.zip

ah OK!
great, it works perfectly. So ready to review if you have time ;)

[smartie2076]

Wouldnt it also be possible to define a function in C0 that checks/adds the maximumCapacity info instead of defining it multiple times (with, I assume, the same code bits) in energyProduction, energyConversion and energyStorage?

[smartie2076]

not correct unit

[Piranias]

what's the correct unit here? there is no row "unit" in energyProviders, so I have to write the unit hardcoded in this cas

[smartie2076]

Please add a description of the maximumCap parameter that you added in the readthedocs parameter description, or if more text is needed in a new custom_constraints.rst page/add it in the simulating_with_the_mvs.rst fild that is in the dev branch.

[Piranias]

Please add a description of the maximumCap parameter that you added in the readthedocs parameter description, or if more text is needed in a new custom_constraints.rst page/add it in the simulating_with_the_mvs.rst fild that is in the dev branch.

I added the parameter here readthedocs parameter description
I didn't find a reasonable spot where to add it in the simulating_with_the_mvs.rst file