New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/multiple in out transformer #949
Conversation
f6c7620
to
09da536
Compare
Multiple outputs and one input mvs_tool -i tests/benchmark_test_inputs/Feature_output_flows_as_list -ext csv -f
Multiple inputs and one output
|
If the transformer has multiple input or multiple output, it is expected that the parameter dispatch_price as well as efficiency is provided twice Co-authored-by: 19248728+NargesChinichian@users.noreply.github.com
f762ea1
to
5266358
Compare
This flagged as failed with newest version of pytest, as it also passed with older version it make sense to change it anyway
91bf56a
to
44dbbe5
Compare
CHANGELOG.md
Outdated
@@ -61,6 +61,7 @@ Here is a template for new release sections | |||
- Calculation of `total_feedin` and `total_consumption_from_providers`, where multiple providers of one energy carrier were not aggregated correctly (#931) | |||
- Used `pandas.concat` instead of `DataFrame.append` to add rows to a `pandas.DataFrame` instance to suppress UserWarning (#937) | |||
- Add missing file for test `test_F0_output.TestLogCreation.test_parse_simulation_log` (#937) | |||
- Transformers can have multiple input or output busses (#949) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe include and refer to where this is tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I only changed the changelog and the tests did not trigger, I will merge as the previous status was passing |
fix #802, fix #799, fix #541, fix #599, fix #507
fix transformer_constant_efficiency_fix to accept multiple inputs OR multiple outputs.
Changes proposed in this pull request:
transformer_constant_efficiency_fix
andtransformer_constant_efficiency_optimize
accepts multiple in/outputs.transformer_constant_efficiency_fix
EFFICIENCY
(conversion_factors
parameter ofTransformer
object) are assigned to input flows and "INSTALLED_CAP"s (nominal_values) are assigned to output.DISPATCH_PRICE
andEFFICIENCY
are provided to output flows and input flow is left emptyDISPATCH_PRICE
,EFFICIENCY
are not provided as a list, there is an error raisedtransformer_constant_efficiency_optimize
DISPATCH_PRICE
s (variable_costs) andEFFICIENCY
(conversion_factors
parameter ofTransformer
object) are assigned to input flows andINSTALLED_CAP
(existing
parameter ofInvestment
object),MAXIMUM_ADD_CAP
(maximum
parameter ofInvestment
object) andSIMULATION_ANNUITY
(ep_costs
parameter ofInvestment
object) are assigned to output.DISPATCH_PRICE
andEFFICIENCY
are provided to output flows and input flow is left emptyDISPATCH_PRICE
,EFFICIENCY
are not provided as a list, there is an error raisedThe following steps were realized, as well (if applies):
black . --exclude docs/
)EXECUTE_TESTS_ON=master pytest
)For more information on how to contribute check the CONTRIBUTING.md.