Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plots #32

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

Improve plots #32

wants to merge 13 commits into from

Conversation

SabineHaas
Copy link
Collaborator

@SabineHaas SabineHaas commented Jun 16, 2022

changes in this PR

  • adapt xticks (no rotation, visual for every subplot)
  • remove year from xticks

@SabineHaas SabineHaas requested a review from jnnr June 16, 2022 15:10
Copy link
Collaborator Author

@SabineHaas SabineHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @MaGering :)

I cannot accept as I cannot be requested as reviewer in my own PR :D

Copy link
Collaborator Author

@SabineHaas SabineHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I've just realized that for the plot where the whole year is shown, this doesn't work. There are far too many entries:
methanation_operation_01-12

@MaGering
Copy link
Collaborator

MaGering commented Jun 16, 2022

Ah, I've just realized that for the plot where the whole year is shown, this doesn't work. There are far too many entries: methanation_operation_01-12

I've fixed that with commit c82529e and 67a8839. The AutoDateLocator takes care now of correct labeling.

@jnnr jnnr added this to the v0.0.2 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants